Address PR review comments

- Remove check_early_hints.js/py from .gitignore (Comment #1)
- Fix ESLint/Prettier issues in check_early_hints.js:
  - Move require('ws') to top of file
  - Replace msgId++ with msgId += 1
  - Wrap single-arg arrow params in parentheses
- Add process.exit(1) when no Chrome tabs found in JS file (Comment #4)
- Add explicit sys.exit() for success/failure in Python file (Comment #5)
- Add language identifiers to fenced code blocks in docs/thruster.md (Comment #6)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: justin808

.gitignore

@@ -67,7 +67,3 @@ client/app/bundles/comments/rescript/**/*.bs.js
 
 .claude/
 .context/
-
-# Chrome DevTools debug scripts (development-only)
-check_early_hints.js
-check_early_hints.py

check_early_hints.js

@@ -1,4 +1,5 @@
 const http = require('http');
+const WebSocket = require('ws');
 
 // Fetch Chrome tabs
 const req = http.get('http://localhost:9222/json', (res) => {
@@ -13,15 +14,14 @@ const req = http.get('http://localhost:9222/json', (res) => {
 
     if (tabs.length === 0) {
       console.log('No Chrome tabs found');
-      return;
+      process.exit(1);
     }
 
     const tab = tabs[0];
     console.log(`📱 Tab: ${tab.title}`);
     console.log(`🔗 URL: ${tab.url}\n`);
 
     // Connect to WebSocket
-    const WebSocket = require('ws');
     const ws = new WebSocket(tab.webSocketDebuggerUrl);
 
     let msgId = 1;
@@ -30,26 +30,32 @@ const req = http.get('http://localhost:9222/json', (res) => {
       console.log('✅ Connected to Chrome DevTools Protocol\n');
 
       // Enable Runtime
-      ws.send(JSON.stringify({
-        id: msgId++,
-        method: 'Runtime.enable'
-      }));
+      ws.send(
+        JSON.stringify({
+          id: msgId,
+          method: 'Runtime.enable',
+        }),
+      );
+      msgId += 1;
 
       // Get HTML content
       setTimeout(() => {
-        ws.send(JSON.stringify({
-          id: msgId++,
-          method: 'Runtime.evaluate',
-          params: {
-            expression: 'document.documentElement.outerHTML'
-          }
-        }));
+        ws.send(
+          JSON.stringify({
+            id: msgId,
+            method: 'Runtime.evaluate',
+            params: {
+              expression: 'document.documentElement.outerHTML',
+            },
+          }),
+        );
+        msgId += 1;
       }, 500);
     });
 
-    ws.on('message', (data) => {
+    ws.on('message', (msgData) => {
       try {
-        const msg = JSON.parse(data);
+        const msg = JSON.parse(msgData);
 
         if (msg.result && msg.result.result && msg.result.result.value) {
           const html = msg.result.result.value;
@@ -62,7 +68,7 @@ const req = http.get('http://localhost:9222/json', (res) => {
           if (earlyHintsMatch) {
             earlyHintsFound = true;
             console.log('🎉 Found Early Hints debug comments in HTML!\n');
-            earlyHintsMatch.forEach(match => {
+            earlyHintsMatch.forEach((match) => {
               console.log(match);
               console.log();
             });
@@ -79,7 +85,7 @@ const req = http.get('http://localhost:9222/json', (res) => {
           const linkMatches = html.match(/<link[^>]*rel=["']preload["'][^>]*>/g);
           if (linkMatches) {
             console.log(`\n📦 Found ${linkMatches.length} preload links in HTML head:`);
-            linkMatches.slice(0, 5).forEach(link => {
+            linkMatches.slice(0, 5).forEach((link) => {
               console.log(`  ${link}`);
             });
           }

check_early_hints.py

@@ -1,5 +1,7 @@
 #!/usr/bin/env python3
 import json
+import re
+import sys
 import urllib.request
 import websocket
 import ssl
@@ -10,7 +12,7 @@
 
 if not tabs:
     print("No Chrome tabs found")
-    exit(1)
+    sys.exit(1)
 
 # Use the first tab (the one we saw with the PR review app)
 tab = tabs[0]
@@ -60,7 +62,6 @@
                     print("🎉 Found Early Hints debug comments in HTML!\n")
 
                     # Extract the comments
-                    import re
                     matches = re.findall(r'<!--[\s\S]*?Early Hints[\s\S]*?-->', html)
                     for match in matches:
                         print(match)
@@ -84,6 +85,8 @@
 
 if found_early_hints:
     print("\n✅ SUCCESS: Early Hints are working!")
+    sys.exit(0)
 else:
     print("\n⚠️  Could not verify Early Hints in the current page state")
     print("The page may need to be reloaded to capture HTTP 103 responses")
+    sys.exit(1)

docs/thruster.md

@@ -41,27 +41,27 @@ After running `bundle install`, the `thrust` executable is available.
 All Procfiles in this project have been updated to use Thruster:
 
 #### Production (`Procfile`)
-```
+```text
 web: bundle exec thrust bin/rails server
 ```
 
 #### Development with HMR (`Procfile.dev`)
-```
+```text
 rails: bundle exec thrust bin/rails server -p 3000
 ```
 
 #### Development with Production Assets (`Procfile.dev-prod-assets`)
-```
+```text
 web: bundle exec thrust bin/rails server -p 3001
 ```
 
 #### Development with Static Webpack (`Procfile.dev-static`)
-```
+```text
 web: bundle exec thrust bin/rails server -p 3000
 ```
 
 #### Development with Static Assets (`Procfile.dev-static-assets`)
-```
+```text
 web: bundle exec thrust bin/rails server -p 3000
 ```
 
@@ -122,7 +122,7 @@ Thruster will automatically:
 
 When the server starts, you'll see Thruster initialization in the logs:
 
-```
+```text
 [thrust] Starting Thruster HTTP/2 proxy
 [thrust] Proxying to http://localhost:3000
 [thrust] Serving from ./public
@@ -134,7 +134,7 @@ When the server starts, you'll see Thruster initialization in the logs:
 
 Thruster works seamlessly with Heroku. The standard `Procfile` is already configured:
 
-```
+```text
 web: bundle exec thrust bin/rails server
 ```
 
@@ -208,7 +208,7 @@ Thruster will automatically:
 
 Thruster logs important events:
 
-```
+```text
 [thrust] Starting Thruster HTTP/2 proxy
 [thrust] Proxying to http://localhost:3000
 [thrust] Serving from ./public
@@ -273,12 +273,12 @@ config.public_file_server.headers = {
 ### From Puma Early Hints
 
 Previous configuration:
-```
+```text
 web: bundle exec puma -C config/puma.rb --early-hints
 ```
 
 New configuration:
-```
+```text
 web: bundle exec thrust bin/rails server
 ```