chore!: remove deprecated "platform-improvements" feedback survey name (#465)

Author: zimeg

cmd/feedback/feedback.go

@@ -68,9 +68,8 @@ const (
 
 // Supported survey names
 const (
-	SlackCLIFeedback                = "slack-cli"
-	SlackPlatformFeedback           = "slack-platform"
-	SlackPlatformFeedbackDeprecated = "platform-improvements" // DEPRECATED(semver:major)
+	SlackCLIFeedback      = "slack-cli"
+	SlackPlatformFeedback = "slack-platform"
 )
 
 type SurveyConfigInterface interface {
@@ -241,12 +240,6 @@ func runFeedbackCommand(ctx context.Context, clients *shared.ClientFactory, cmd
 		return nil
 	}
 
-	// DEPRECATED(semver:major): Support the deprecated survey name for backwards compatibility
-	if surveyNameFlag == SlackPlatformFeedbackDeprecated {
-		surveyNameFlag = SlackPlatformFeedback
-		clients.IO.PrintWarning(ctx, "DEPRECATED: The '--name %s' flag is deprecated; use '--name %s' instead", SlackPlatformFeedbackDeprecated, SlackPlatformFeedback)
-	}
-
 	surveyNames, surveyPromptOptions := initSurveyOpts(ctx, clients, SurveyStore)
 
 	if _, ok := SurveyStore[surveyNameFlag]; !ok && surveyNameFlag != "" {

cmd/feedback/feedback_test.go

@@ -263,17 +263,6 @@ func TestShowSurveyMessages(t *testing.T) {
 
 func Test_Feedback_FeedbackCommand(t *testing.T) {
 	testutil.TableTestCommand(t, testutil.CommandTests{
-		// DEPRECATED(semver:major): Support the deprecated survey name for backwards compatibility
-		"supports deprecated --name platform-improvements": {
-			CmdArgs: []string{"--name", "platform-improvements"},
-			Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {
-				setupFeedbackCommandMocks(t, ctx, cm, cf)
-			},
-			ExpectedOutputs: []string{
-				"feedback@slack.com",
-				"https://docs.slack.dev/developer-support",
-			},
-		},
 		"supports --name slack-cli": {
 			CmdArgs: []string{"--name", "slack-cli"},
 			Setup: func(t *testing.T, ctx context.Context, cm *shared.ClientsMock, cf *shared.ClientFactory) {