Skip to content

Commit 99873c6

Browse files
Rename RequestRefusedError -> RefusedError.
1 parent af8cb2e commit 99873c6

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

lib/protocol/http/error.rb

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,14 @@ module HTTP
99
class Error < StandardError
1010
end
1111

12-
# Raised when a request was not processed by the server and can be safely retried, even for non-idempotent methods.
13-
class RequestRefusedError < Error
12+
# Raised when an HTTP stream or request was refused before any processing occurred.
13+
# In the case of requests, it indicates that the request was refused before any processing occurred, and can be safely retried.
14+
class RefusedError < Error
1415
end
1516

17+
# @deprecated Use {RefusedError} instead.
18+
RequestRefusedError = RefusedError
19+
1620
# Represents a bad request error (as opposed to a server error).
1721
# This is used to indicate that the request was malformed or invalid.
1822
module BadRequest

releases.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## v0.61.0
44

5-
- Introduce `Protocol::HTTP::RequestRefusedError` for indicating a request was not processed by the server and can be safely retried.
5+
- Introduce `Protocol::HTTP::RefusedError` for indicating a stream or request was refused before processing and can be safely retried. `RequestRefusedError` is provided as an alias for backwards compatibility.
66

77
## v0.60.0
88

test/protocol/http/error.rb

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,22 @@
55

66
require "protocol/http/error"
77

8-
describe Protocol::HTTP::RequestRefusedError do
9-
let(:error) {subject.new("GOAWAY: request not processed.")}
8+
describe Protocol::HTTP::RefusedError do
9+
let(:error) {subject.new("Stream refused.")}
1010

1111
with "#initialize" do
1212
it "is an HTTP error" do
1313
expect(error).to be_a(Protocol::HTTP::Error)
1414
end
1515

1616
it "has a descriptive message" do
17-
expect(error.message).to be == "GOAWAY: request not processed."
17+
expect(error.message).to be == "Stream refused."
1818
end
1919
end
20+
21+
it "is aliased as RequestRefusedError" do
22+
expect(Protocol::HTTP::RequestRefusedError).to be == Protocol::HTTP::RefusedError
23+
end
2024
end
2125

2226
describe Protocol::HTTP::DuplicateHeaderError do

0 commit comments

Comments
 (0)