Remove NavigationService and Navigation app to save RAM

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: sofar

src/CMakeLists.txt

@@ -375,7 +375,6 @@ list(APPEND SOURCE_FILES
         displayapp/screens/SystemInfo.cpp
         displayapp/screens/Label.cpp
         displayapp/screens/FirmwareUpdate.cpp
-        displayapp/screens/Navigation.cpp
         displayapp/screens/Metronome.cpp
         displayapp/screens/Motion.cpp
         displayapp/screens/Weather.cpp
@@ -457,7 +456,6 @@ list(APPEND SOURCE_FILES
         components/ble/CurrentTimeService.cpp
         components/ble/AlertNotificationService.cpp
         components/ble/SimpleWeatherService.cpp
-        components/ble/NavigationService.cpp
         components/ble/BatteryInformationService.cpp
         components/ble/FSService.cpp
         components/ble/ImmediateAlertService.cpp
@@ -531,7 +529,6 @@ list(APPEND RECOVERY_SOURCE_FILES
         components/ble/FSService.cpp
         components/ble/ImmediateAlertService.cpp
         components/ble/ServiceDiscovery.cpp
-        components/ble/NavigationService.cpp
         components/ble/HeartRateService.cpp
         components/ble/MotionService.cpp
         components/firmwarevalidator/FirmwareValidator.cpp

src/components/ble/NimbleController.cpp

@@ -88,7 +88,6 @@ void NimbleController::Init() {
   currentTimeClient.Init();
   currentTimeService.Init();
   weatherService.Init();
-  navService.Init();
   anService.Init();
   dfuService.Init();
   batteryInformationService.Init();

src/components/ble/NimbleController.h

@@ -17,7 +17,6 @@
 #include "components/ble/FSService.h"
 #include "components/ble/HeartRateService.h"
 #include "components/ble/ImmediateAlertService.h"
-#include "components/ble/NavigationService.h"
 #include "components/ble/ServiceDiscovery.h"
 #include "components/ble/MotionService.h"
 #include "components/ble/SimpleWeatherService.h"
@@ -54,10 +53,6 @@ namespace Pinetime {
       int OnGAPEvent(ble_gap_event* event);
       void StartDiscovery();
 
-      Pinetime::Controllers::NavigationService& navigation() {
-        return navService;
-      };
-
       Pinetime::Controllers::AlertNotificationService& alertService() {
         return anService;
       };
@@ -94,7 +89,6 @@ namespace Pinetime {
       AlertNotificationClient alertNotificationClient;
       CurrentTimeService currentTimeService;
       SimpleWeatherService weatherService;
-      NavigationService navService;
       BatteryInformationService batteryInformationService;
       ImmediateAlertService immediateAlertService;
       HeartRateService heartRateService;

src/displayapp/Controllers.h

@@ -24,7 +24,6 @@ namespace Pinetime {
     class SimpleWeatherService;
     class FS;
     class Timer;
-    class NavigationService;
   }
 
   namespace System {
@@ -50,7 +49,6 @@ namespace Pinetime {
       Pinetime::System::SystemTask* systemTask;
       Pinetime::Applications::DisplayApp* displayApp;
       Pinetime::Components::LittleVgl& lvgl;
-      Pinetime::Controllers::NavigationService* navigationService;
     };
   }
 }

src/displayapp/DisplayApp.cpp

@@ -17,7 +17,6 @@
 #include "displayapp/screens/Paddle.h"
 #include "displayapp/screens/StopWatch.h"
 #include "displayapp/screens/Metronome.h"
-#include "displayapp/screens/Navigation.h"
 #include "displayapp/screens/Notifications.h"
 #include "displayapp/screens/SystemInfo.h"
 #include "displayapp/screens/Tile.h"
@@ -126,8 +125,7 @@ DisplayApp::DisplayApp(Drivers::St7789& lcd,
                  timer,
                  nullptr,
                  this,
-                 lvgl,
-                 nullptr} {
+                 lvgl} {
 }
 
 void DisplayApp::Start(System::BootErrors error) {
@@ -722,10 +720,6 @@ void DisplayApp::Register(Pinetime::Controllers::SimpleWeatherService* weatherSe
   this->controllers.weatherController = weatherService;
 }
 
-void DisplayApp::Register(Pinetime::Controllers::NavigationService* NavigationService) {
-  this->controllers.navigationService = NavigationService;
-}
-
 void DisplayApp::ApplyBrightness() {
   auto brightness = settingsController.GetBrightness();
   if (brightness != Controllers::BrightnessController::Levels::Low && brightness != Controllers::BrightnessController::Levels::Medium &&

src/displayapp/DisplayApp.h

@@ -79,7 +79,6 @@ namespace Pinetime {
 
       void Register(Pinetime::System::SystemTask* systemTask);
       void Register(Pinetime::Controllers::SimpleWeatherService* weatherService);
-      void Register(Pinetime::Controllers::NavigationService* NavigationService);
 
     private:
       Pinetime::Drivers::St7789& lcd;

src/displayapp/DisplayAppRecovery.cpp

@@ -117,6 +117,3 @@ void DisplayApp::Register(Pinetime::System::SystemTask* /*systemTask*/) {
 
 void DisplayApp::Register(Pinetime::Controllers::SimpleWeatherService* /*weatherService*/) {
 }
-
-void DisplayApp::Register(Pinetime::Controllers::NavigationService* /*NavigationService*/) {
-}

src/displayapp/DisplayAppRecovery.h

@@ -36,7 +36,6 @@ namespace Pinetime {
     class BrightnessController;
     class FS;
     class SimpleWeatherService;
-    class NavigationService;
   }
 
   namespace System {
@@ -72,7 +71,6 @@ namespace Pinetime {
       void PushMessage(Pinetime::Applications::Display::Messages msg);
       void Register(Pinetime::System::SystemTask* systemTask);
       void Register(Pinetime::Controllers::SimpleWeatherService* weatherService);
-      void Register(Pinetime::Controllers::NavigationService* NavigationService);
 
     private:
       TaskHandle_t taskHandle;

src/displayapp/apps/Apps.h.in

@@ -21,7 +21,6 @@ namespace Pinetime {
       Paddle,
       Twos,
       HeartRate,
-      Navigation,
       StopWatch,
       Metronome,
       Motion,

src/displayapp/apps/CMakeLists.txt

@@ -11,7 +11,6 @@ else ()
     set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Twos")
     set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Dice")
     set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Metronome")
-    set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Navigation")
     set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Calculator")
     set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Weather")
     #set(DEFAULT_USER_APP_TYPES "${DEFAULT_USER_APP_TYPES}, Apps::Motion")