Merge pull request #405 from oedotme/main

fix: state updates detection on history back/forward

Author: ryansolid

.changeset/lucky-dingos-happen.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/router": patch
+---
+
+Fix state updates detection on history back/forward

src/routers/createRouter.ts

@@ -32,7 +32,9 @@ export function createRouter(config: {
   let ignore = false;
   const wrap = (value: string | LocationChange) => (typeof value === "string" ? { value } : value);
   const signal = intercept<LocationChange>(
-    createSignal(wrap(config.get()), { equals: (a, b) => a.value === b.value }),
+    createSignal(wrap(config.get()), {
+      equals: (a, b) => a.value === b.value && a.state === b.state
+    }),
     undefined,
     next => {
       !ignore && config.set(next);

src/routing.ts

@@ -337,17 +337,15 @@ export function createRouterContext(
     const { value, state } = source();
     // Untrack this whole block so `start` doesn't cause Solid's Listener to be preserved
     untrack(() => {
-      if (value !== reference()) {
-        start(() => {
-          intent = "native";
-          setReference(value);
-          setState(state);
-          resetErrorBoundaries();
-          submissions[1]([]);
-        }).then(() => {
-          intent = undefined;
-        });
-      }
+      start(() => {
+        intent = "native";
+        if (value !== reference()) setReference(value);
+        setState(state);
+        resetErrorBoundaries();
+        submissions[1]([]);
+      }).then(() => {
+        intent = undefined;
+      });
     });
   });