Error out if symbol points to the end of stringtab

ssbssa · ssbssa · commit 389946fdaafd · 2024-07-07T18:56:01.000+02:00
Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30668
diff --git a/gdb/coffread.c b/gdb/coffread.c
@@ -1306,7 +1306,7 @@ getsymname (struct internal_syment *symbol_entry)
 
   if (symbol_entry->_n._n_n._n_zeroes == 0)
     {
-      if (symbol_entry->_n._n_n._n_offset > stringtab_length)
+      if (symbol_entry->_n._n_n._n_offset >= stringtab_length)
 	error (_("COFF Error: string table offset (%s) outside string table (length %ld)"),
 	       hex_string (symbol_entry->_n._n_n._n_offset), stringtab_length);
       result = stringtab + symbol_entry->_n._n_n._n_offset;

Original file line number	Diff line number	Diff line change
`@@ -1306,7 +1306,7 @@ getsymname (struct internal_syment *symbol_entry)`
`1306`	`1306`
`1307`	`1307`	`if (symbol_entry->_n._n_n._n_zeroes == 0)`
`1308`	`1308`	`{`
`1309`		`- if (symbol_entry->_n._n_n._n_offset > stringtab_length)`
	`1309`	`+ if (symbol_entry->_n._n_n._n_offset >= stringtab_length)`
`1310`	`1310`	`error (_("COFF Error: string table offset (%s) outside string table (length %ld)"),`
`1311`	`1311`	`hex_string (symbol_entry->_n._n_n._n_offset), stringtab_length);`
`1312`	`1312`	`result = stringtab + symbol_entry->_n._n_n._n_offset;`