fix: add max_items to duckdb client (#229)

Closes #228

Author: gadomski

python/rustac/rustac.pyi

@@ -96,6 +96,7 @@ class DuckdbClient:
         collections: str | list[str] | None = None,
         intersects: str | dict[str, Any] | None = None,
         limit: int | None = None,
+        max_items: int | None = None,
         offset: int | None = None,
         bbox: list[float] | None = None,
         datetime: str | None = None,
@@ -116,6 +117,8 @@ class DuckdbClient:
             intersects: Searches items by performing intersection between their
                 geometry and provided GeoJSON geometry.
             limit: The number of items to return.
+            max_items: The number of items to return (included so that we have a
+                similar call API to normal search)
             offset: The number of items to skip before returning.
             bbox: Requested bounding box.
             datetime: Single date+time, or a range (`/` separator), formatted to

src/duckdb.rs

@@ -61,15 +61,16 @@ impl DuckdbClient {
         Ok(count)
     }
 
-    #[pyo3(signature = (href, *, intersects=None, ids=None, collections=None, limit=None, bbox=None, datetime=None, include=None, exclude=None, sortby=None, filter=None, query=None, **kwargs))]
+    #[pyo3(signature = (href, *, intersects=None, ids=None, collections=None, limit=None, max_items=None, bbox=None, datetime=None, include=None, exclude=None, sortby=None, filter=None, query=None, **kwargs))]
     fn search<'py>(
         &self,
         py: Python<'py>,
         href: String,
         intersects: Option<StringOrDict>,
         ids: Option<StringOrList>,
         collections: Option<StringOrList>,
-        limit: Option<u64>,
+        mut limit: Option<u64>,
+        max_items: Option<u64>,
         bbox: Option<Vec<f64>>,
         datetime: Option<String>,
         include: Option<StringOrList>,
@@ -79,6 +80,12 @@ impl DuckdbClient {
         query: Option<Bound<'py, PyDict>>,
         kwargs: Option<Bound<'py, PyDict>>,
     ) -> Result<Bound<'py, PyList>> {
+        if max_items.is_some() {
+            if limit.is_some() {
+                tracing::warn!("Both max_items and limit are set, overriding limit with max_items");
+            }
+            limit = max_items;
+        }
         let search = crate::search::build(
             intersects,
             ids,

tests/test_duckdb.py

@@ -95,3 +95,9 @@ def test_aws_credential_chain(client: DuckdbClient) -> None:
 def test_search_union_by_name(client: DuckdbClient) -> None:
     items = client.search("data/*.parquet")
     assert len(items) == 101
+
+
+def test_max_items_type(client: DuckdbClient) -> None:
+    # https://github.com/stac-utils/rustac-py/issues/228
+    items = client.search("data/*.parquet", max_items=1)
+    assert len(items) == 1