Skip to content

Commit 4fbffca

Browse files
qdequippemaxhelias
authored andcommitted
Add streamReads option to GoogleCloudStorage Adapter
1 parent fee448c commit 4fbffca

File tree

3 files changed

+7
-0
lines changed

3 files changed

+7
-0
lines changed

docs/2-cloud-storage-providers.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ flysystem:
104104
client: 'gcloud_client_service' # The service ID of the Google\Cloud\Storage\StorageClient instance
105105
bucket: 'bucket_name'
106106
prefix: 'optional/path/prefix'
107+
streamReads: false
107108
```
108109
109110
## DigitalOcean Spaces

src/Adapter/Builder/GcloudAdapterDefinitionBuilder.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,9 @@ protected function configureOptions(OptionsResolver $resolver): void
4848

4949
$resolver->setDefault('visibility_handler', null);
5050
$resolver->setAllowedTypes('visibility_handler', ['string', 'null']);
51+
52+
$resolver->setDefault('streamReads', false);
53+
$resolver->setAllowedTypes('streamReads', 'bool');
5154
}
5255

5356
protected function configureDefinition(Definition $definition, array $options, ?string $defaultVisibilityForDirectories): void
@@ -65,5 +68,6 @@ protected function configureDefinition(Definition $definition, array $options, ?
6568
$definition->setArgument(0, $bucketDefinition);
6669
$definition->setArgument(1, $options['prefix']);
6770
$definition->setArgument(2, $visibilityHandlerReference);
71+
$definition->setArgument(5, $options['streamReads']);
6872
}
6973
}

tests/Adapter/Builder/GcloudAdapterDefinitionBuilderTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@ public function testOptionsBehavior(): void
6767
'bucket' => 'bucket_name',
6868
'prefix' => 'prefix/path',
6969
'visibility_handler' => UniformBucketLevelAccessVisibility::class,
70+
'streamReads' => true,
7071
], null);
7172

7273
$this->assertSame(GoogleCloudStorageAdapter::class, $definition->getClass());
@@ -80,6 +81,7 @@ public function testOptionsBehavior(): void
8081
$this->assertSame('bucket', $bucketDefinition->getFactory()[1]);
8182

8283
$this->assertSame('prefix/path', $definition->getArgument(1));
84+
$this->assertTrue($definition->getArgument(5));
8385

8486
/** @var Reference $visibilityHandlerReference */
8587
$visibilityHandlerReference = $definition->getArgument(2);

0 commit comments

Comments
 (0)