ruff_lint_format

Author: kellerza

.github/workflows/python-app.yml

@@ -23,44 +23,15 @@ jobs:
         with:
           args: "check --fix"
           version: ${{ env.RUFF_VERSION }}
-      # A proposal to replace black & pylint
-      # - uses: chartboost/ruff-action@v1
-      #   with:
-      #     args: "format --check"
-      #     version: ${{ env.RUFF_VERSION }}
-
-  black:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6
-      - uses: actions/setup-python@v3
-        with:
-          python-version: ${{ env.DEFAULT_PYTHON }}
-      - uses: psf/black@24.4.2
-
-  pylint:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v6
-      - uses: actions/setup-python@v4
-        with:
-          python-version: ${{ env.DEFAULT_PYTHON }}
-      - name: Install uv
-        uses: astral-sh/setup-uv@v7
+      - uses: chartboost/ruff-action@v1
         with:
-          version: ${{ env.UV_VERSION }}
-      - name: Install Requirements
-        run: uv sync --frozen --all-extras
-      - name: Run Pylint
-        run: |
-          uv run pylint office365
+          args: "format --check"
+          version: ${{ env.RUFF_VERSION }}
 
   pytest:
     runs-on: ubuntu-latest
     needs:
       - ruff
-      - black
-      - pylint
     steps:
       - uses: actions/checkout@v6
       - name: Set up Python ${{ env.DEFAULT_PYTHON }}

.isort.cfg

@@ -20,22 +20,8 @@ repos:
         language: system
         pass_filenames: false
 
-      # A proposal to replace black & pylint
-      # - id: ruff-format
-      #   name: ruff-format
-      #   entry: uv run ruff format --exit-non-zero-on-fix
-      #   language: system
-      #   pass_filenames: false
-
-      - id: black
-        name: black
-        entry: uv run black .
+      - id: ruff-format
+        name: ruff-format
+        entry: uv run ruff format --exit-non-zero-on-fix
         language: system
         pass_filenames: false
-
-      - id: pylint
-        name: pylint
-        entry: uv run pylint office365
-        language: system
-        pass_filenames: false
-

.pre-commit-config.yaml

@@ -51,9 +51,7 @@ prek run --all-files
 
 The project uses the following tools (mirroring CI):
 
-- Black (formatting)
-- Ruff (linting and import sorting)
-- Pylint (static analysis)
+- Ruff (linting and formatting)
 
 Line length: 121 characters (configured in `pyproject.toml`).
 
@@ -127,10 +125,7 @@ CI note: Full E2E tests in CI rely on repository secrets and may not run on fork
 ### Pull Request Process
 
 1. CI Checks must pass:
-   - Ruff linting
-   - Black formatting
-   - Pylint analysis
-   - Pytest execution
+   - Ruff linting and formatting
 2. Await maintainer review
 3. Update documentation where applicable
 

CONTRIBUTING.md

@@ -13,7 +13,7 @@
     test_user_principal_name,
 )
 
-client = GraphClient(
-    tenant=test_tenant, environment=AzureEnvironment.USGovernmentHigh
-).with_client_secret(test_client_id, test_client_secret)
+client = GraphClient(tenant=test_tenant, environment=AzureEnvironment.USGovernmentHigh).with_client_secret(
+    test_client_id, test_client_secret
+)
 messages = client.users[test_user_principal_name].messages.get().execute_query()

examples/auth/gcc_high.py

@@ -5,13 +5,9 @@
     test_tenant,
 )
 
-client = GraphClient(tenant=test_tenant).with_client_secret(
-    test_client_id, test_client_secret
-)
+client = GraphClient(tenant=test_tenant).with_client_secret(test_client_id, test_client_secret)
 
-resource = client.service_principals.get_by_app_id(
-    "00000003-0000-0ff1-ce00-000000000000"
-)
+resource = client.service_principals.get_by_app_id("00000003-0000-0ff1-ce00-000000000000")
 # principal = client.service_principals.get_by_app_id(test_client_id).get().execute_query()
 result = resource.get_application_permissions(test_client_id).execute_query()
 for app_role in result.value:

examples/auth/sharepoint/list_permissions.py

@@ -20,12 +20,8 @@
 from office365.graph_client import GraphClient
 from tests import test_client_id, test_client_secret, test_tenant
 
-client = GraphClient(tenant=test_tenant).with_client_secret(
-    test_client_id, test_client_secret
-)
+client = GraphClient(tenant=test_tenant).with_client_secret(test_client_id, test_client_secret)
 # client = GraphClient(tenant=test_tenant).with_token_interactive(test_client_id)
-resource = client.service_principals.get_by_app_id(
-    MsAppIds.Office_365_SharePoint_Online
-)
+resource = client.service_principals.get_by_app_id(MsAppIds.Office_365_SharePoint_Online)
 app = client.applications.get_by_app_id(test_client_id)
 resource.grant_application_permissions(app, "Sites.FullControl.All").execute_query()

examples/auth/sharepoint/register_apponly.py

@@ -21,9 +21,7 @@ def acquire_token():
         authority=authority_url,
         client_credential=credentials,
     )
-    result = app.acquire_token_for_client(
-        scopes=["https://graph.microsoft.com/.default"]
-    )
+    result = app.acquire_token_for_client(scopes=["https://graph.microsoft.com/.default"])
     return result
 
 

examples/auth/with_client_cert.py

@@ -11,8 +11,6 @@
 from office365.graph_client import GraphClient
 from tests import test_client_id, test_client_secret, test_tenant
 
-client = GraphClient(tenant=test_tenant).with_client_secret(
-    test_client_id, test_client_secret
-)
+client = GraphClient(tenant=test_tenant).with_client_secret(test_client_id, test_client_secret)
 root_site = client.sites.root.get().execute_query()
 print(root_site.web_url)

examples/auth/with_client_secret.py

@@ -7,8 +7,6 @@
 from office365.graph_client import GraphClient
 from tests import test_client_id, test_password, test_tenant, test_username
 
-client = GraphClient(tenant=test_tenant).with_username_and_password(
-    test_client_id, test_username, test_password
-)
+client = GraphClient(tenant=test_tenant).with_username_and_password(test_client_id, test_username, test_password)
 me = client.me.get().execute_query()
 print(me)