Skip to content

Commit f9f4a0b

Browse files
committed
Added ccm- in front of the aws ccm OTE project folder for clarity.
1 parent d7ba970 commit f9f4a0b

9 files changed

Lines changed: 16 additions & 16 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ azure-config-credentials-injector:
5151
go build -o bin/azure-config-credentials-injector cmd/azure-config-credentials-injector/main.go
5252

5353
cloud-controller-manager-aws-tests-ext:
54-
cd openshift-tests/aws-tests && \
54+
cd openshift-tests/ccm-aws-tests && \
5555
mkdir -p ../bin && \
5656
go build $(GOGCFLAGS) -o "../bin/cloud-controller-manager-aws-tests-ext" \
5757
-trimpath -ldflags "$(LD_FLAGS)" .

go.work

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,6 @@ go 1.25.0
22

33
use (
44
.
5-
./openshift-tests/aws-tests
5+
./openshift-tests/ccm-aws-tests
66
./openshift-tests/operator-tests
77
)

openshift-tests/README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This directory contains OpenShift Tests Extension (OTE) binaries for testing the
66

77
The test suite is organized into separate sub-projects, each with independent dependencies:
88

9-
- **`aws-tests/`** - AWS-specific cloud controller manager tests
9+
- **`ccm-aws-tests/`** - AWS-specific cloud controller manager tests
1010
- `e2e/aws/` - AWS-specific test implementations
1111
- `e2e/common/` - Common helper functions (feature gate checks)
1212
- `main.go` - Binary entry point
@@ -60,7 +60,7 @@ The test suite is organized into separate sub-projects, each with independent de
6060

6161
## Test Organization
6262

63-
### AWS Tests (`aws-tests/e2e/`)
63+
### AWS Tests (`ccm-aws-tests/e2e/`)
6464

6565
- `aws/helper.go` - AWS helper functions (feature gate checks, AWS clients)
6666
- `aws/loadbalancer.go` - AWS NLB and load balancer tests
@@ -85,14 +85,14 @@ The test suite is organized into separate sub-projects, each with independent de
8585
### Adding New Tests
8686

8787
1. Add test files to the appropriate sub-project's `e2e/` directory:
88-
- `aws-tests/e2e/aws/` - AWS-specific tests
89-
- `aws-tests/e2e/common/` - AWS-specific shared helpers
88+
- `ccm-aws-tests/e2e/aws/` - AWS-specific tests
89+
- `ccm-aws-tests/e2e/common/` - AWS-specific shared helpers
9090
- `operator-tests/e2e/operator/` - Operator tests
9191
- `operator-tests/e2e/common/` - Operator-specific shared helpers
9292

9393
2. Import the test package in the binary's `main.go` (blank import for side effects):
9494
```go
95-
import _ "github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/aws-tests/e2e/aws"
95+
import _ "github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/ccm-aws-tests/e2e/aws"
9696
```
9797

9898
3. Tests are automatically discovered by the OTE framework via Ginkgo suite scanning
@@ -109,7 +109,7 @@ make cloud-controller-manager-aws-tests-ext cluster-cloud-controller-manager-ope
109109
make build
110110

111111
# Or build individually from within each sub-project
112-
cd openshift-tests/aws-tests && go build -o ../bin/cloud-controller-manager-aws-tests-ext .
112+
cd openshift-tests/ccm-aws-tests && go build -o ../bin/cloud-controller-manager-aws-tests-ext .
113113
cd openshift-tests/operator-tests && go build -o ../bin/cluster-cloud-controller-manager-operator-tests-ext .
114114
```
115115

@@ -150,19 +150,19 @@ Each sub-project has its own `go.mod` file, allowing independent dependency mana
150150
./hack/go-mod.sh
151151

152152
# Or update a specific sub-project independently
153-
cd openshift-tests/aws-tests && go mod tidy
153+
cd openshift-tests/ccm-aws-tests && go mod tidy
154154
cd openshift-tests/operator-tests && go mod tidy
155155
```
156156

157157
The `hack/go-mod.sh` script (run from project root):
158-
- Tidies all modules in the workspace (root, aws-tests, operator-tests)
158+
- Tidies all modules in the workspace (root, ccm-aws-tests, operator-tests)
159159
- Syncs workspace dependencies via `go work sync`
160160
- Re-tidies after sync to apply version bumps
161161
- Verifies all modules
162162
- Creates unified vendor directory
163163

164164
**Benefits of separate modules:**
165-
- AWS SDK updates only affect `aws-tests/` - operator tests remain stable
165+
- AWS SDK updates only affect `ccm-aws-tests/` - operator tests remain stable
166166
- Each binary can update dependencies independently without blocking the other
167167
- Faster, more focused dependency updates
168168
- Reduced dependency bloat (operator tests don't pull in AWS SDK)
@@ -173,7 +173,7 @@ The `hack/go-mod.sh` script (run from project root):
173173

174174
This directory contains multiple Go modules organized as a workspace:
175175
- Root module: `github.com/openshift/cluster-cloud-controller-manager-operator`
176-
- AWS tests: `github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/aws-tests`
176+
- AWS tests: `github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/ccm-aws-tests`
177177
- Operator tests: `github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/operator-tests`
178178

179179
All modules are coordinated via the workspace defined in `../go.work`.

openshift-tests/aws-tests/e2e/aws/helper.go renamed to openshift-tests/ccm-aws-tests/e2e/aws/helper.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
ec2types "github.com/aws/aws-sdk-go-v2/service/ec2/types"
1212
elbv2 "github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2"
1313
elbv2types "github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2/types"
14-
"github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/aws-tests/e2e/common"
14+
"github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/ccm-aws-tests/e2e/common"
1515
"k8s.io/kubernetes/test/e2e/framework"
1616
)
1717

File renamed without changes.
File renamed without changes.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/aws-tests
1+
module github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/ccm-aws-tests
22

33
go 1.25.0
44

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ import (
2020
log "github.com/sirupsen/logrus"
2121

2222
// Importing ginkgo tests from the CCM e2e packages
23-
_ "github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/aws-tests/e2e/aws"
24-
_ "github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/aws-tests/e2e/common"
23+
_ "github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/ccm-aws-tests/e2e/aws"
24+
_ "github.com/openshift/cluster-cloud-controller-manager-operator/openshift-tests/ccm-aws-tests/e2e/common"
2525
_ "k8s.io/cloud-provider-aws/tests/e2e"
2626
)
2727

0 commit comments

Comments
 (0)