Merge pull request #1537 from luhring/panic-at-the-nil-sbom

luhring · web-flow · commit d124cd52a72d · 2025-04-10T18:48:48.000-04:00
fix(scan): avoid panic by handling err from SBOM gen
diff --git a/pkg/cli/scan.go b/pkg/cli/scan.go
@@ -270,8 +270,10 @@ func scanEverything(ctx context.Context, p *scanParams, inputs []string, advisor
 			if err := errs[i]; err != nil {
 				if p.outputFormat == outputFormatOutline {
 					fmt.Printf("❌ Skipping scan because SBOM generation failed for %q: %v\n", input, err)
-					continue
 				}
+
+				// All errs will get joined and returned at the end of the outer function.
+				continue
 			}
 
 			file := files[i]

Original file line number	Diff line number	Diff line change
`@@ -270,8 +270,10 @@ func scanEverything(ctx context.Context, p *scanParams, inputs []string, advisor`
`270`	`270`	`if err := errs[i]; err != nil {`
`271`	`271`	`if p.outputFormat == outputFormatOutline {`
`272`	`272`	`fmt.Printf("❌ Skipping scan because SBOM generation failed for %q: %v\n", input, err)`
`273`		`- continue`
`274`	`273`	`}`
	`274`	`+`
	`275`	`+ // All errs will get joined and returned at the end of the outer function.`
	`276`	`+ continue`
`275`	`277`	`}`
`276`	`278`
`277`	`279`	`file := files[i]`