refactor: remove pre-verification flag

Author: MarcosNicolau

aggregation_mode/src/aggregators/risc0_aggregator.rs

@@ -15,11 +15,8 @@ pub enum AlignedRisc0VerificationError {
 }
 
 impl Risc0ProofReceiptAndImageId {
-    pub fn new(image_id: [u8; 32], receipt: Receipt) -> Self {
-        Self { image_id, receipt }
-    }
-
-    pub fn new_with_verification(
+    /// Constructs a new instance of the struct, verifying the provided receipt against the given image ID.
+    pub fn new(
         image_id: [u8; 32],
         receipt: Receipt,
     ) -> Result<Self, AlignedRisc0VerificationError> {

aggregation_mode/src/aggregators/sp1_aggregator.rs

@@ -37,17 +37,8 @@ pub enum AlignedSP1VerificationError {
 }
 
 impl SP1ProofWithPubValuesAndElf {
-    pub fn new(proof_with_pub_values: SP1ProofWithPublicValues, elf: Vec<u8>) -> Self {
-        let vk = vk_from_elf(&elf);
-
-        Self {
-            proof_with_pub_values,
-            elf,
-            vk,
-        }
-    }
-
-    pub fn new_with_verification(
+    /// Constructs a new instance of the struct by verifying a given SP1 proof with its public values.
+    pub fn new(
         proof_with_pub_values: SP1ProofWithPublicValues,
         elf: Vec<u8>,
     ) -> Result<Self, AlignedSP1VerificationError> {

aggregation_mode/src/backend/config.rs

@@ -22,7 +22,6 @@ pub struct Config {
     pub last_aggregated_block_filepath: String,
     pub ecdsa: ECDSAConfig,
     pub proofs_per_chunk: u16,
-    pub pre_verification_enabled: bool,
     pub total_proofs_limit: u16,
 }
 

aggregation_mode/src/backend/fetcher.rs

@@ -30,7 +30,6 @@ pub struct ProofsFetcher {
     rpc_provider: RPCProvider,
     aligned_service_manager: AlignedLayerServiceManagerContract,
     last_aggregated_block: u64,
-    pre_verification_enabled: bool,
 }
 
 impl ProofsFetcher {
@@ -49,7 +48,6 @@ impl ProofsFetcher {
             rpc_provider,
             aligned_service_manager,
             last_aggregated_block,
-            pre_verification_enabled: config.pre_verification_enabled,
         }
     }
 
@@ -120,14 +118,10 @@ impl ProofsFetcher {
 
                         let elf = p.vm_program_code?;
                         let proof_with_pub_values = bincode::deserialize(&p.proof).ok()?;
-                        let sp1_proof = if self.pre_verification_enabled {
-                            SP1ProofWithPubValuesAndElf::new_with_verification(
-                                proof_with_pub_values,
-                                elf,
-                            )
-                        } else {
-                            Ok(SP1ProofWithPubValuesAndElf::new(proof_with_pub_values, elf))
-                        };
+                        let sp1_proof = SP1ProofWithPubValuesAndElf::new_with_verification(
+                            proof_with_pub_values,
+                            elf,
+                        );
 
                         match sp1_proof {
                             Ok(proof) => Some(AlignedProof::SP1(proof.into())),
@@ -152,11 +146,8 @@ impl ProofsFetcher {
                             bincode::deserialize(&p.proof).ok()?;
 
                         let receipt = Receipt::new(inner_receipt, public_inputs);
-                        let risc0_proof = if self.pre_verification_enabled {
-                            Risc0ProofReceiptAndImageId::new_with_verification(image_id, receipt)
-                        } else {
-                            Ok(Risc0ProofReceiptAndImageId::new(image_id, receipt))
-                        };
+                        let risc0_proof =
+                            Risc0ProofReceiptAndImageId::new_with_verification(image_id, receipt);
 
                         match risc0_proof {
                             Ok(proof) => Some(AlignedProof::Risc0(proof.into())),

config-files/config-proof-aggregator-ethereum-package.yaml

@@ -5,7 +5,6 @@ eth_ws_url: "ws://localhost:8546"
 max_proofs_in_queue: 1000
 last_aggregated_block_filepath: config-files/proof-aggregator.last_aggregated_block.json
 proofs_per_chunk: 512 # Amount of proofs to process per chunk
-pre_verification_enabled: true
 # This number comes from the blob data limit
 # Since each blob has a capacity of (4096 * 32) = 131.072 bytes
 # But to not surpass the field modulus we pad with a 0xo byte so we have (4096 * 31) = 126.976 bytes

config-files/config-proof-aggregator-mock-ethereum-package.yaml

@@ -5,7 +5,6 @@ eth_ws_url: "ws://localhost:8546"
 max_proofs_in_queue: 1000
 last_aggregated_block_filepath: config-files/proof-aggregator.last_aggregated_block.json
 proofs_per_chunk: 512 # Amount of proofs to process per chunk
-pre_verification_enabled: true
 # This number comes from the blob data limit
 # Since each blob has a capacity of (4096 * 32) = 131.072 bytes
 # But to not surpass the field modulus we pad with a 0xo byte so we have (4096 * 31) = 126.976 bytes

config-files/config-proof-aggregator-mock.yaml

@@ -5,7 +5,6 @@ eth_ws_url: "ws://localhost:8545"
 max_proofs_in_queue: 1000
 last_aggregated_block_filepath: config-files/proof-aggregator.last_aggregated_block.json
 proofs_per_chunk: 512 # Amount of proofs to process per chunk
-pre_verification_enabled: true
 # This number comes from the blob data limit
 # Since each blob has a capacity of (4096 * 32) = 131.072 bytes
 # But to not surpass the field modulus we pad with a 0xo byte so we have (4096 * 31) = 126.976 bytes

config-files/config-proof-aggregator.yaml

@@ -5,7 +5,6 @@ eth_ws_url: "ws://localhost:8545"
 max_proofs_in_queue: 1000
 last_aggregated_block_filepath: config-files/proof-aggregator.last_aggregated_block.json
 proofs_per_chunk: 512 # Amount of proofs to process per chunk
-pre_verification_enabled: true
 # This number comes from the blob data limit
 # Since each blob has a capacity of (4096 * 32) = 131.072 bytes
 # But to not surpass the field modulus we pad with a 0xo byte so we have (4096 * 31) = 126.976 bytes