feat: zisk write program ids

Author: MarcosNicolau

aggregation_mode/proof_aggregator/aggregation_programs/Cargo.lock

@@ -5,9 +5,11 @@ use lambdaworks_crypto::merkle_tree::merkle::MerkleTree;
 use zisk_aggregation_program::{ChunkAggregatorInput, Hash32};
 
 // Generated with `make proof_aggregator_write_program_ids` and copied from program_ids.json
-pub const USER_PROOFS_AGGREGATOR_PROGRAM_VK_HASH: [u8; 32] = [
-    86, 146, 102, 198, 206, 75, 142, 66, 123, 251, 236, 150, 2, 205, 75, 142, 237, 255, 93, 54, 2,
-    16, 190, 188, 246, 3, 188, 241, 235, 64, 220, 228,
+pub const USER_PROOFS_AGGREGATOR_PROGRAM_ROM_ROOT: [u64; 4] = [
+    9552917093105913802,
+    7845128850459495418,
+    6121665346010988278,
+    15056293071596476132,
 ];
 
 pub fn main() {
@@ -18,12 +20,6 @@ pub fn main() {
 
     // Verify the proofs.
     for (proof, leaves_commitment) in input.proofs_and_leaves_commitment {
-        // Ensure the aggregated chunk originates from the user proofs aggregation program.
-        // This validation step guarantees that the proof was genuinely verified
-        // by this program. Without this check, a different program using the
-        // same public inputs could bypass verification.
-        assert!(proof.vk.clone() == USER_PROOFS_AGGREGATOR_PROGRAM_VK_HASH);
-
         let proof_words = bytemuck::cast_slice::<u8, u64>(&proof.proof);
 
         // Reading public inputs as done in the verify of the lib at https://github.com/0xPolygonHermez/zisk/blob/maint/checkouts/pil2-proofman-3d49384e4e2f0af7/78497c5/verifier/src/verifier.rs#L66-L73
@@ -32,12 +28,24 @@ pub fn main() {
         p += 1;
 
         // we should end up with a vector of length 4 as the public input is a 256 bits digest
+        let mut rom_vkey: [u64; 4] = [0_u64; 4];
         let mut publics = Vec::new();
-        for _ in 0..n_public_inputs {
+        for i in 0..n_public_inputs {
+            // The first 4 entries are the rom vkey
+            if i < 4 {
+                rom_vkey[i as usize] = proof_words[p];
+            }
+
             publics.push(proof_words[p]);
             p += 1;
         }
 
+        // Ensure the aggregated chunk originates from the user proofs aggregation program.
+        // This validation step guarantees that the proof was genuinely verified
+        // by this program. Without this check, a different program using the
+        // same public inputs could bypass verification.
+        assert!(rom_vkey == USER_PROOFS_AGGREGATOR_PROGRAM_ROM_ROOT);
+
         let merkle_root_words: [u64; 4] = publics
             .try_into()
             .expect("Public input to be the hash of the chunk tree");

aggregation_mode/proof_aggregator/aggregation_programs/zisk/elf/zisk_chunk_aggregator_program

@@ -0,0 +1 @@
+�Q�P�[��YDHX/�Uks�`~=��u�	�

aggregation_mode/proof_aggregator/aggregation_programs/zisk/elf/zisk_user_proofs_aggregator_program

@@ -0,0 +1 @@
+��U�{ǒ������l��;2��T�֮�Ʋ��

aggregation_mode/proof_aggregator/aggregation_programs/zisk/src/chunk_aggregator_main.rs

@@ -1,5 +1,5 @@
 use alloy::hex;
-use proof_aggregator::aggregators::{risc0_aggregator, sp1_aggregator};
+use proof_aggregator::aggregators::{risc0_aggregator, sp1_aggregator, zisk_aggregator};
 use serde_json::json;
 use sp1_sdk::HashableKey;
 use std::{fs, path::Path};
@@ -16,7 +16,9 @@ fn main() {
     let subscriber = FmtSubscriber::builder().finish();
     tracing::subscriber::set_global_default(subscriber).expect("setting default subscriber failed");
 
-    info!("About to write sp1 programs vk hash bytes + risc0 programs image id bytes");
+    info!(
+        "About to write sp1 programs vk hash bytes + risc0 programs image id bytes + zisk rom vk"
+    );
     let sp1_user_proofs_aggregator_vk_hash =
         sp1_aggregator::vk_from_elf(SP1_USER_PROOFS_AGGREGATOR_PROGRAM_ELF).bytes32_raw();
     let sp1_user_proofs_aggregator_vk_hash_words =
@@ -29,6 +31,9 @@ fn main() {
     let risc0_chunk_aggregator_image_id_bytes =
         risc0_aggregator::RISC0_CHUNK_AGGREGATOR_PROGRAM_ID_BYTES;
 
+    let zisk_user_proofs_aggregator_rom_vk = zisk_aggregator::USER_PROOFS_PROGRAM_ROM_VK;
+    let zisk_chunk_aggregator_rom_vk_hex = hex::encode(zisk_aggregator::CHUNK_PROGRAM_ROM_VK_BYTES);
+
     let sp1_user_proofs_aggregator_vk_hash_hex = hex::encode(sp1_user_proofs_aggregator_vk_hash);
     let sp1_chunk_aggregator_vk_hash_hex = hex::encode(sp1_chunk_aggregator_vk_hash);
     let risc0_user_proofs_aggregator_image_id_hex =
@@ -44,6 +49,8 @@ fn main() {
         "risc0_user_proofs_aggregator_image_id": format!("0x{}", risc0_user_proofs_aggregator_image_id_hex),
         "risc0_user_proofs_aggregator_image_id_bytes": format!("{:?}", risc0_user_proofs_aggregator_image_id_bytes),
         "risc0_chunk_aggregator_image_id": format!("0x{}", risc0_chunk_aggregator_imaged_id_hex),
+        "zisk_user_proofs_aggregator_rom_vk": format!("{:?}", zisk_user_proofs_aggregator_rom_vk),
+        "zisk_chunk_aggregator_rom_vk_hex": format!("0x{}", zisk_chunk_aggregator_rom_vk_hex)
     });
 
     // Write to the file

aggregation_mode/proof_aggregator/aggregation_programs/zisk/vk/zisk_chunk_aggregator_program

@@ -58,9 +58,14 @@ fn main() {
     let zisk_rustc_path = rustc_path_for("zisk");
 
     let mut build_command = std::process::Command::new("cargo-zisk");
+
     let mut user_proof_aggregator_rom_setup_command = std::process::Command::new("cargo-zisk");
     let mut chunk_aggregator_rom_setup_command = std::process::Command::new("cargo-zisk");
 
+    let mut user_proof_aggregator_rom_vk_command = std::process::Command::new("cargo-zisk");
+    let mut chunk_aggregator_rom_vk_command = std::process::Command::new("cargo-zisk");
+
+    // Zisk build elf command
     build_command
         .env("RUSTC", &zisk_rustc_path)
         .args(["build", "--release"])
@@ -74,6 +79,7 @@ fn main() {
         panic!("Failed to build zisk elfs");
     }
 
+    // Zisk rom-setup commands
     let user_proof_aggregator_rom_setup_status = user_proof_aggregator_rom_setup_command
         .args([
             "rom-setup",
@@ -104,6 +110,41 @@ fn main() {
         panic!("Failed to execute rom-setup command on chunk aggregator program");
     }
 
+    // Zisk rom-vkey commands
+    let user_proofs_aggregator_rom_vkey_status = user_proof_aggregator_rom_vk_command
+        .args([
+            "rom-vkey",
+            "--elf",
+            "./target/riscv64ima-zisk-zkvm-elf/release/zisk_user_proofs_aggregator_program",
+            "-o",
+            "zisk/vk/zisk_user_proofs_aggregator_program",
+        ])
+        .env("RUSTC", &zisk_rustc_path)
+        .current_dir("./aggregation_programs/")
+        .status()
+        .unwrap();
+
+    if !user_proofs_aggregator_rom_vkey_status.success() {
+        panic!("Failed to execute rom-vkey command on user proofs aggregator program");
+    }
+
+    let chunk_aggregator_rom_vkey_status = chunk_aggregator_rom_vk_command
+        .args([
+            "rom-vkey",
+            "--elf",
+            "./target/riscv64ima-zisk-zkvm-elf/release/zisk_chunk_aggregator_program",
+            "-o",
+            "zisk/vk/zisk_chunk_aggregator_program",
+        ])
+        .env("RUSTC", &zisk_rustc_path)
+        .current_dir("./aggregation_programs/")
+        .status()
+        .unwrap();
+
+    if !chunk_aggregator_rom_vkey_status.success() {
+        panic!("Failed to execute rom-vkey command on chunk aggregator program");
+    }
+
     let _ = std::fs::create_dir("./aggregation_programs/zisk/elf");
 
     std::fs::copy(

aggregation_mode/proof_aggregator/aggregation_programs/zisk/vk/zisk_user_proofs_aggregator_program

@@ -4,5 +4,7 @@
   "risc0_user_proofs_aggregator_image_id_bytes": "[86, 146, 102, 198, 206, 75, 142, 66, 123, 251, 236, 150, 2, 205, 75, 142, 237, 255, 93, 54, 2, 16, 190, 188, 246, 3, 188, 241, 235, 64, 220, 228]",
   "sp1_chunk_aggregator_vk_hash": "0x00d6e32a34f68ea643362b96615591c94ee0bf99ee871740ab2337966a4f77af",
   "sp1_user_proofs_aggregator_vk_hash": "0x00a0fe3e73d4dd5f66369c60629213c8a037da04f8f68724c8a15ed1d20a0d5e",
-  "sp1_user_proofs_aggregator_vk_hash_words": "[1350508345, 1966561241, 1188269068, 690044042, 29282343, 1675238547, 289586595, 1376390494]"
+  "sp1_user_proofs_aggregator_vk_hash_words": "[1350508345, 1966561241, 1188269068, 690044042, 29282343, 1675238547, 289586595, 1376390494]",
+  "zisk_chunk_aggregator_rom_vk_hex": "0xfd518d50ee1b5bfe9e594448582fc8556b7313e2607e3d1f10a1d475800912b0",
+  "zisk_user_proofs_aggregator_rom_vk": "[9552917093105913802, 7845128850459495418, 6121665346010988278, 15056293071596476132]"
 }

aggregation_mode/proof_aggregator/bin/write_program_image_id_vk_hash.rs

@@ -10,6 +10,10 @@ RISC0_USER_PROOFS_AGGREGATOR_IMAGE_ID_BYTES=`jq -r .risc0_user_proofs_aggregator
 RISC0_LINE="pub const USER_PROOFS_AGGREGATOR_PROGRAM_IMAGE_ID: [u8; 32] = $RISC0_USER_PROOFS_AGGREGATOR_IMAGE_ID_BYTES;\n"
 sed -i '' -e "/^pub const USER_PROOFS_AGGREGATOR_PROGRAM_IMAGE_ID.*/{N;N;N;s|.*|$RISC0_LINE|;}" aggregation_programs/risc0/src/chunk_aggregator_main.rs
 
+ZISK_USER_PROOFS_AGGREGATOR_ROM_VK=`jq -r .zisk_user_proofs_aggregator_rom_vk programs_ids.json`
+ZISK_LINE="pub const USER_PROOFS_AGGREGATOR_PROGRAM_ROM_ROOT: [u64; 4] = $ZISK_USER_PROOFS_AGGREGATOR_ROM_VK;\n"
+sed -i '' -e "/^pub const USER_PROOFS_AGGREGATOR_PROGRAM_ROM_ROOT.*/{N;N;N;N;N;s|.*|$ZISK_LINE|;}" aggregation_programs/zisk/src/chunk_aggregator_main.rs
+
 cd aggregation_programs
 cargo fmt --all