Add a timeout for the get receipt final calls as alloy does not provide one

Author: maximopalopoli

aggregation_mode/proof_aggregator/src/backend/config.rs

@@ -26,6 +26,7 @@ pub struct Config {
     pub base_bump_percentage: u64,
     pub max_fee_bump_percentage: u64,
     pub priority_fee_wei: u128,
+    pub final_receipt_check_timeout_seconds: u64,
 }
 
 impl Config {

aggregation_mode/proof_aggregator/src/backend/mod.rs

@@ -423,33 +423,46 @@ impl ProofAggregator {
             }
         }
 
+        let receipt_timeout = Duration::from_secs(self.config.final_receipt_check_timeout_seconds);
+
         // After exhausting all retry attempts, we iterate over every pending transaction hash
         // that was previously submitted with the same nonce but different gas parameters.
         // One of these transactions may have been included in a block while we were still
         // retrying and waiting on others. By explicitly checking the receipt for each hash,
         // we ensure we don't "lose" a transaction that was actually mined but whose receipt
         // we never observed due to timeouts during earlier attempts.
         for (i, tx_hash) in pending_hashes.into_iter().enumerate() {
-            match self
-                .proof_aggregation_service
-                .provider()
-                .get_transaction_receipt(tx_hash)
-                .await
+            // NOTE: `get_transaction_receipt` has no built-in timeout, so we guard it to
+            // avoid hanging the aggregator on a stuck RPC call.
+            match tokio::time::timeout(
+                receipt_timeout,
+                self.proof_aggregation_service
+                    .provider()
+                    .get_transaction_receipt(tx_hash),
+            )
+            .await
             {
-                Ok(Some(receipt)) => {
+                Ok(Ok(Some(receipt))) => {
                     info!("Pending tx #{} confirmed; returning receipt", i + 1);
                     return Ok(receipt);
                 }
-                Ok(None) => {
+                Ok(Ok(None)) => {
                     warn!(
                         "Pending tx #{} still no receipt yet (hash {})",
                         i + 1,
                         tx_hash
                     );
                 }
-                Err(err) => {
+                Ok(Err(err)) => {
                     warn!("Pending tx #{} receipt query failed: {:?}", i + 1, err);
                 }
+                Err(_) => {
+                    warn!(
+                        "Pending tx #{} receipt query timed out after {:?}",
+                        i + 1,
+                        receipt_timeout
+                    );
+                }
             }
         }
 

config-files/config-proof-aggregator-ethereum-package.yaml

@@ -32,7 +32,8 @@ max_bump_retries: 5
 bump_retry_interval_seconds: 120
 base_bump_percentage: 10
 max_fee_bump_percentage: 100
-priority_fee_wei: 3000000000 // 3 Gwei
+priority_fee_wei: 3000000000 # 3 Gwei
+final_receipt_check_timeout_seconds: 5
 
 ecdsa:
   private_key_store_path: "config-files/anvil.proof-aggregator.ecdsa.key.json"

config-files/config-proof-aggregator.yaml

@@ -32,7 +32,8 @@ max_bump_retries: 5
 bump_retry_interval_seconds: 120
 base_bump_percentage: 10
 max_fee_bump_percentage: 100
-priority_fee_wei: 3000000000 // 3 Gwei
+priority_fee_wei: 3000000000 # 3 Gwei
+final_receipt_check_timeout_seconds: 5
 
 ecdsa:
   private_key_store_path: "config-files/anvil.proof-aggregator.ecdsa.key.json"