Skip to content

Commit f73d455

Browse files
authored
fix: telemetry spans (#1670)
1 parent b0d08c4 commit f73d455

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

telemetry_api/lib/telemetry_api/periodically.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,14 +48,14 @@ defmodule TelemetryApi.Periodically do
4848
PrometheusMetrics.new_gas_price(gas_price)
4949

5050
{:error, error} ->
51-
IO.inspect("Error fetching gas price: #{error}")
51+
Logger.error("Error fetching gas price: #{inspect(error)}")
5252
end
5353
{:noreply, %{}}
5454
end
5555
defp fetch_operators_info() do
5656
case Operators.fetch_all_operators() do
5757
:ok -> :ok
58-
{:error, message} -> IO.inspect("Couldn't fetch operators: #{IO.inspect(message)}")
58+
{:error, message} -> Logger.error("Couldn't fetch operators: #{inspect(message)}")
5959
end
6060
end
6161

@@ -67,7 +67,7 @@ defmodule TelemetryApi.Periodically do
6767
Operators.update_operator(op, %{status: string_status(status)})
6868

6969
error ->
70-
Logger.error("Error when updating status: #{error}")
70+
Logger.error("Error when updating status: #{inspect(error)}")
7171
end
7272
end)
7373
:ok

telemetry_api/lib/telemetry_api/traces.ex

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ defmodule TelemetryApi.Traces do
9696
)
9797

9898
IO.inspect(
99-
"Operator response included. merkle_root: #{IO.inspect(merkle_root)} operator_id: #{IO.inspect(operator_id)}"
99+
"Operator response included. merkle_root: #{inspect(merkle_root)} operator_id: #{inspect(operator_id)}"
100100
)
101101

102102
:ok
@@ -129,11 +129,6 @@ defmodule TelemetryApi.Traces do
129129
| subspans: Map.delete(trace.subspans, :batcher)
130130
})
131131

132-
with {:ok, _trace} <- set_current_trace(merkle_root) do
133-
Tracer.end_span()
134-
TraceStore.delete_trace(merkle_root)
135-
end
136-
137132
:ok
138133
end
139134
end

0 commit comments

Comments
 (0)