Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new xtask subcommand (validate-members) intended to ensure all internal workspace path dependencies are also present in the root workspace members, and wires it into xtask precheck.
Changes:
- Introduce
ValidateMembersxtask to validate (and optionally fix) missing workspace members. - Run
ValidateMembersas part ofxtask precheckby default. - Update root workspace
memberslist and addtoml_editas a workspace dependency (and toxtask).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
xtask/src/validate_members.rs |
Implements the new ValidateMembers command (validate + optional fix). |
xtask/src/precheck.rs |
Adds a --validate-members stage and runs it by default. |
xtask/src/main.rs |
Registers the new ValidateMembers subcommand/module. |
xtask/Cargo.toml |
Adds toml_edit dependency for the new xtask. |
Cargo.toml |
Adds missing workspace members and introduces toml_edit to [workspace.dependencies]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a new xtask, ValidateMembers, that will check (and optionally fix) if any internal path dependency is missing from the workspace members in the repository's root ./Cargo.toml file.