Skip to content

[build] add ValidateMembers xtask#325

Open
zimmy87 wants to merge 2 commits intomainfrom
user/v-davidz/validate_workspace_members
Open

[build] add ValidateMembers xtask#325
zimmy87 wants to merge 2 commits intomainfrom
user/v-davidz/validate_workspace_members

Conversation

@zimmy87
Copy link
Copy Markdown
Contributor

@zimmy87 zimmy87 commented Apr 15, 2026

This change adds a new xtask, ValidateMembers, that will check (and optionally fix) if any internal path dependency is missing from the workspace members in the repository's root ./Cargo.toml file.

Copilot AI review requested due to automatic review settings April 15, 2026 19:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new xtask subcommand (validate-members) intended to ensure all internal workspace path dependencies are also present in the root workspace members, and wires it into xtask precheck.

Changes:

  • Introduce ValidateMembers xtask to validate (and optionally fix) missing workspace members.
  • Run ValidateMembers as part of xtask precheck by default.
  • Update root workspace members list and add toml_edit as a workspace dependency (and to xtask).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
xtask/src/validate_members.rs Implements the new ValidateMembers command (validate + optional fix).
xtask/src/precheck.rs Adds a --validate-members stage and runs it by default.
xtask/src/main.rs Registers the new ValidateMembers subcommand/module.
xtask/Cargo.toml Adds toml_edit dependency for the new xtask.
Cargo.toml Adds missing workspace members and introduces toml_edit to [workspace.dependencies].

Comment thread xtask/src/validate_members.rs
Comment thread Cargo.toml
Comment thread xtask/src/validate_members.rs
@zimmy87 zimmy87 linked an issue Apr 15, 2026 that may be closed by this pull request
@zimmy87 zimmy87 marked this pull request as ready for review April 15, 2026 22:47
Copilot AI review requested due to automatic review settings April 15, 2026 22:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make xtask to validate workspace members

2 participants