Skip to content

fix: avoid mutating redirect chain array when formatting #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AI-Reviewer-QS wants to merge 1 commit into from
Closed

fix: avoid mutating redirect chain array when formatting #974

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/formatters/NetworkFormatter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ export class NetworkFormatter {
if (redirectChain.length) {
response.push(`### Redirect chain`);
let indent = 0;
for (const request of redirectChain.reverse()) {
for (const request of [...redirectChain].reverse()) {
const id = this.#options.requestIdResolver
? this.#options.requestIdResolver(request)
: undefined;
Expand Down Expand Up @@ -191,7 +191,7 @@ export class NetworkFormatter {

toJSONDetailed(): object {
const redirectChain = this.#request.redirectChain();
const formattedRedirectChain = redirectChain.reverse().map(request => {
const formattedRedirectChain = [...redirectChain].reverse().map(request => {
const id = this.#options.requestIdResolver
? this.#options.requestIdResolver(request)
: undefined;
Expand Down