Add styles parameter to manual_legend (Redo)#1117
Open
tktran wants to merge 4 commits intoDistrictDataLabs:developfrom
Open
Add styles parameter to manual_legend (Redo)#1117tktran wants to merge 4 commits intoDistrictDataLabs:developfrom
tktran wants to merge 4 commits intoDistrictDataLabs:developfrom
Conversation
Sets up tests/test_gridsearch with basic tests based on sample .ipynb. Only one change to gridsearch code (quick method return changed from None to visualizer).
Added styles parameter to manual_legend per issue DistrictDataLabs#566. With tests and bug fix for existing manual_legend test. (2nd fork after original deleted)
This reverts commit 5ebca26.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[This is a redo of pull request #1094, since I (the contributor of the original PR) accidentally deleted the fork referenced by that PR.]
[One change from the original PR: the original PR included both the manual_legend styles code and code committed as part of #1097. I reverted the commit associated with 1097, so that this PR that you are looking at involves manual_legend improvements only.]
This PR is intended to fully implement issue #566. It includes unit tests for the new feature, and a bug fix for the existing manual_legend test (which failed to enable drawing the legend in the test image). It does not include updated documentation, which I would gladly begin working on upon approval of this PR. Also open to your suggested changes.
Questions for the DistrictDataLabs/team-oz-maintainers:
Checklist:
pytest?