Fix issue #1330: Remove distutils dependency for Python 3.12+ compatibility#1334
Open
edschofield wants to merge 1 commit intoDistrictDataLabs:developfrom
Open
Fix issue #1330: Remove distutils dependency for Python 3.12+ compatibility#1334edschofield wants to merge 1 commit intoDistrictDataLabs:developfrom
edschofield wants to merge 1 commit intoDistrictDataLabs:developfrom
Conversation
…on 3.12+ compatibility distutils was removed from the stdlib in Python 3.12. Yellowbrick only used distutils to check whether matplotlib >= 1.5.0, a version that is now ancient history, even though Yellowbrick depends on Matplotlib >= 2.0.2. This patch removes the version checks and obsolete workarounds for older versions of matplotlib.
|
@edschofield Thank you! I was hitting this same bug in my workflow, and installing from this PR fixed it for me. I very much appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distutils was removed from the stdlib in Python 3.12. Yellowbrick only used distutils to check whether matplotlib >= 1.5.0, a version that is now ancient history, even though Yellowbrick depends on Matplotlib >= 2.0.2.
This patch removes the version checks and obsolete workarounds for older versions of matplotlib.
This is inspired by this commit but cleaner, omitting many unrelated modifications to test images.