Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

[#308] Some Images missing "alt" property#319

Open
abdqudus wants to merge 2 commits intoEddieHubCommunity:mainfrom
abdqudus:Mybranch
Open

[#308] Some Images missing "alt" property#319
abdqudus wants to merge 2 commits intoEddieHubCommunity:mainfrom
abdqudus:Mybranch

Conversation

@abdqudus
Copy link
Copy Markdown

@abdqudus abdqudus commented Dec 17, 2023

Closes #308

This pull request addresses missing alt property in some images reported in #308 . The changes iinclude setting the alt value to the name of the person testifying.

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Fixes EddieHubCommunity#308

This pull request addresses missing alt property in some images reported in EddieHubCommunity#308 .
The changes iinclude setting the alt value to the name of the person testifying.
@vercel
Copy link
Copy Markdown

vercel bot commented Dec 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2023 4:24pm

Comment thread src/components/Testimonials.jsx Outdated
'.png'
}
alt=""
alt={`${testimonial.author.name} image}
Copy link
Copy Markdown
Member

@kkrishguptaa kkrishguptaa Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alt={`${testimonial.author.name} image}
alt={`${testimonial.author.name}'s profile picture`}

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I will do that now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some Images missing "alt" property

3 participants