Skip to content

Add Terraform support for Dashboard Chart for v1 endpoint#17404

Open
divyamjain000 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
divyamjain000:chronicle-dashboardchart-divyamjain
Open

Add Terraform support for Dashboard Chart for v1 endpoint#17404
divyamjain000 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
divyamjain000:chronicle-dashboardchart-divyamjain

Conversation

@divyamjain000
Copy link
Copy Markdown
Contributor

This commit introduces Terraform resources for the Google Chronicle Data Table Row v1 API, including:

  • google_chronicle_dashboard_chart

Fixes hashicorp/terraform-provider-google#27214

Release Note Template for Downstream PRs (will be copied)

`google_chronicle_dashboard_chart` (ga)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3201683:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 7758 insertions(+), 10 deletions(-)
google-beta provider View Diff 3 files changed, 4 insertions(+), 18 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample
🔴 TestAccChronicleDashboardChart_chronicleDashboardchartFullExample
🔴 TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages
  • chronicle

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log

@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 3201683!

@ankitgoyal0301
Copy link
Copy Markdown
Contributor

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3201683:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 5 files changed, 7758 insertions(+), 10 deletions(-)
google-beta provider View Diff 3 files changed, 4 insertions(+), 18 deletions(-)

Test report

Important

Manual Verification Required (GA-only additions)

The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:

🔴 TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample 🔴 TestAccChronicleDashboardChart_chronicleDashboardchartFullExample 🔴 TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages

  • chronicle

Learn how VCR tests work

Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log

@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 3201683!

Can you confirm here too about local GA test running?

@divyamjain000
Copy link
Copy Markdown
Contributor Author

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3201683:

Diff report

Your PR generated the following diffs in downstream repositories:
Repository Diff Link Changes
google provider View Diff 5 files changed, 7758 insertions(+), 10 deletions(-)
google-beta provider View Diff 3 files changed, 4 insertions(+), 18 deletions(-)

Test report

Important
Manual Verification Required (GA-only additions)
The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually:
🔴 TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample 🔴 TestAccChronicleDashboardChart_chronicleDashboardchartFullExample 🔴 TestAccChronicleDashboardChart_chronicleDashboardchartFullExample_update

Analytics

Total Tests Passed Skipped Affected
38 37 1 0
Affected Service Packages

  • chronicle

Learn how VCR tests work
Step 1: Replaying Mode
🟢 All tests passed in Replaying mode! No Recording was needed.
Caution
Issues requiring attention before PR completion
🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.
Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.
View the build log
@divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 3201683!

Can you confirm here too about local GA test running?

Yes, this has been tested and verified locally in test for GA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Terraform Support for Chronicle Dashboard Chart Resources (v1 API)

3 participants