Add Terraform support for Dashboard Chart for v1 endpoint#17404
Add Terraform support for Dashboard Chart for v1 endpoint#17404divyamjain000 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 3201683: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportImportant Manual Verification Required (GA-only additions) The following tests are GA-only additions and cannot be run by VCR in Beta mode. Please verify them manually: 🔴 TestAccChronicleDashboardChart_chronicleDashboardchartBasicExample Analytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. Caution Issues requiring attention before PR completion 🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the build log @divyamjain000, @trodge, @ankitgoyal0301 VCR tests complete for 3201683! |
Can you confirm here too about local GA test running? |
Yes, this has been tested and verified locally in test for GA. |
This commit introduces Terraform resources for the Google Chronicle Data Table Row v1 API, including:
google_chronicle_dashboard_chartFixes hashicorp/terraform-provider-google#27214
Release Note Template for Downstream PRs (will be copied)