Skip to content

Add support for Firestore field.ttl_config.expiration_offset.#17410

Draft
eddavisson wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
eddavisson:expiration-offset2
Draft

Add support for Firestore field.ttl_config.expiration_offset.#17410
eddavisson wants to merge 3 commits intoGoogleCloudPlatform:mainfrom
eddavisson:expiration-offset2

Conversation

@eddavisson
Copy link
Copy Markdown
Contributor

Add support for Firestore field.ttl_config.expiration_offset.

firestore: added `ttl_config.expiration_offset` field to `google_firestore_field` resource

@github-actions github-actions Bot requested a review from roaks3 May 4, 2026 18:43
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7205097:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 55 insertions(+), 18 deletions(-)
google-beta provider View Diff 4 files changed, 55 insertions(+), 18 deletions(-)
terraform-google-conversion View Diff 1 file changed, 28 insertions(+), 12 deletions(-)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_firestore_field (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_firestore_field" "primary" {
  ttl_config {
    expiration_offset = # value needed
  }
}

Test report

Analytics

Total Tests Passed Skipped Affected
37 35 0 2
Affected Service Packages
  • firestore

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreField_firestoreFieldTimestampWithTtlOffsetExample
  • TestAccFirestoreField_firestoreFieldUpdateAddTTLExample

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccFirestoreField_firestoreFieldTimestampWithTtlOffsetExample 🟢 Passed [Debug log] 🟢 Passed
TestAccFirestoreField_firestoreFieldUpdateAddTTLExample 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@eddavisson, @roaks3 VCR tests complete for 7205097!

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 4, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit e375ddc:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 157 insertions(+), 18 deletions(-)
google-beta provider View Diff 4 files changed, 157 insertions(+), 18 deletions(-)
terraform-google-conversion View Diff 1 file changed, 28 insertions(+), 12 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 35 0 2
Affected Service Packages
  • firestore

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreField_firestoreFieldTimestampWithTtlOffsetExample
  • TestAccFirestoreField_firestoreFieldUpdateAddTTLExample

View the build log


Step 2: Recording Mode

Test Name Recording Mode Replaying Rerun
TestAccFirestoreField_firestoreFieldTimestampWithTtlOffsetExample 🟢 Passed [Debug log] 🟢 Passed
TestAccFirestoreField_firestoreFieldUpdateAddTTLExample 🔴 Failed [Error message] [Debug log] -

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the build log or the debug logs folder for detailed results.

@eddavisson, @roaks3 VCR tests complete for e375ddc!

@eddavisson eddavisson marked this pull request as draft May 4, 2026 20:07
@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 5, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 014f670:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 147 insertions(+), 10 deletions(-)
google-beta provider View Diff 4 files changed, 147 insertions(+), 10 deletions(-)
terraform-google-conversion View Diff 1 file changed, 11 insertions(+), 4 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
37 36 0 1
Affected Service Packages
  • firestore

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccFirestoreField_firestoreFieldTimestampWithTtlOffsetExample

View the build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccFirestoreField_firestoreFieldTimestampWithTtlOffsetExample

🟢 All tests passed!

View the build log or the debug logs folder for detailed results.

@eddavisson, @roaks3 VCR tests complete for 014f670!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants