Skip to content

Migrate resource_compute_target_pool_test to use transport_tpg.SendRequest#17434

Open
iliatsuprik wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
iliatsuprik:target_pool_test
Open

Migrate resource_compute_target_pool_test to use transport_tpg.SendRequest#17434
iliatsuprik wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
iliatsuprik:target_pool_test

Conversation

@iliatsuprik
Copy link
Copy Markdown
Contributor

Release Note Template for Downstream PRs (will be copied)

This change migrates TestAccComputeTargetPool_basic and helper methods to use transport_tpg.SendRequest instead of NewClient

compute: migrated `resource_compute_target_pool_test.go.tmpl` test to use direct HTTP rather than a client library

@modular-magician
Copy link
Copy Markdown
Collaborator

modular-magician commented May 6, 2026

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 8a65267:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 1 file changed, 19 insertions(+), 7 deletions(-)
google-beta provider View Diff 1 file changed, 19 insertions(+), 7 deletions(-)

Test report

Analytics

Total Tests Passed Skipped Affected
1428 1337 91 0
Affected Service Packages
  • compute

Learn how VCR tests work


Step 1: Replaying Mode

🟢 All tests passed in Replaying mode! No Recording was needed.

View the build log

@iliatsuprik VCR tests complete for 8a65267!

@iliatsuprik iliatsuprik changed the title Migrate resource_compute_target_pool_test to use transport_tpg.SendRe… Migrate resource_compute_target_pool_test to use transport_tpg.SendRequest May 6, 2026
@iliatsuprik iliatsuprik marked this pull request as ready for review May 6, 2026 16:24
@github-actions github-actions Bot requested a review from trodge May 6, 2026 16:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants