Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roll up and merge #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Roll up and merge #59
Changes from 4 commits
a72f0a2d93c677b9ecaa9689c1b0a67eb46File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
grep -cis using a pattern with|alternation (e.g.,^def |^class), but plaingreptreats|literally (BRE) so the counts will be wrong. Usegrep -cE(or escape as\|) so the complexity/size heuristic reports accurate numbers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow runs on
synchronizeevents, so thecreateCommentcall will post a new automated comment on every push to the PR, which can quickly spam PR timelines. Consider limiting commenting toopened/reopened, or check for an existing bot comment before creating a new one (and update/edit instead).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This utility script is placed in the root directory. To maintain a clean project structure, it is recommended to move such scripts into a dedicated directory like
scripts/ortools/.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grep pattern
\$((.*))is not a valid way to match$((...))in grep BRE (parentheses are literals), so this check likely won’t find what it intends. If the goal is to detect shell arithmetic expansions, prefer a simpler/robust pattern like searching for the literal$(((and optionally))) or usegrep -Ewith properly escaped parentheses.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script currently returns a success exit code (0) regardless of whether problematic patterns are found, because the
|| echo ...construct suppresses the non-zero exit code fromgrep. If this script is intended for use in CI/CD pipelines to validate code quality, it should be modified to exit with a non-zero status when issues are detected.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.