Edit Metadata Form fix for CVoc fields#12390
Open
qqmyers wants to merge 1 commit intoIQSS:developfrom
Open
Conversation
qqmyers
added
GDCC: QDR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: #8500 fixed #7895 for normal fields but didn't apply the same fix to fields using CVoc. This PR does that. This stops cases such as when the user selects aa plain text author when using an ORCID CVoc script and then tries to manually enter some other type of ID. Without this fix, hitting return in the Identifier field tries to save the metadata form immediately.
Which issue(s) this PR closes:
Special notes for your reviewer: Basically cut/paste of the earlier solution to suppress the normal processing of hitting the enter key.
Suggestions on how to test this: As above, configure the people.js script (or others) on the author field and try adding a text name and then a random Identifier, hit enter.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: no one has reported the issue...
Additional documentation: