Skip to content

variants/XMC4700/config: Modified analog macros.#422

Merged
LinjingZhang merged 1 commit into4.0.0-pre-releasefrom
xmc-bug-analog
Jan 15, 2026
Merged

variants/XMC4700/config: Modified analog macros.#422
LinjingZhang merged 1 commit into4.0.0-pre-releasefrom
xmc-bug-analog

Conversation

@dineshgit411
Copy link
Copy Markdown
Contributor

@dineshgit411 dineshgit411 commented Jan 14, 2026

By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---

CONTRIBUTING.md also tells you what to expect in the PR process.

Description
Compilation errors when including #include <arm_match.h> in example .ino file.
https://jirard.intra.infineon.com/browse/DESMAKERS-4110

Signed-off-by: MDin <Dinesh.M-EE@infineon.com>
@dineshgit411 dineshgit411 marked this pull request as ready for review January 14, 2026 11:27
Copy link
Copy Markdown
Contributor

@LinjingZhang LinjingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all 4700 tests passes. looks good!
Please apply this change to analog pins in all board configuration.

A small suggestion: perhaps you could include a link to the Jira ticket to provide reviewers with more background information.

@dineshgit411
Copy link
Copy Markdown
Contributor Author

all 4700 tests passes. looks good! Please apply this change to analog pins in all board configuration.

A small suggestion: perhaps you could include a link to the Jira ticket to provide reviewers with more background information.

other boards working fine without this modification.. The problem arise in xmc4700..

@LinjingZhang LinjingZhang self-requested a review January 15, 2026 13:10
@LinjingZhang
Copy link
Copy Markdown
Contributor

LinjingZhang commented Jan 15, 2026

all 4700 tests passes. looks good! Please apply this change to analog pins in all board configuration.
A small suggestion: perhaps you could include a link to the Jira ticket to provide reviewers with more background information.

other boards working fine without this modification.. The problem arise in xmc4700..

After some research, I found that the xmc1x series doesn't have this issue because the m0 core doesn't have DSP, so no modification is needed.
However, my personal opinion is that we should still avoid macros like A0, A1..., which are very short and prone to causing global namespace pollution. But this is a matter of personal preference regarding clean code and has nothing to do with this bug, so I will approve it.

@LinjingZhang LinjingZhang merged commit f8b4c97 into 4.0.0-pre-release Jan 15, 2026
412 of 445 checks passed
@LinjingZhang LinjingZhang deleted the xmc-bug-analog branch January 15, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants