Conversation
This reverts PRs #2742 and #2859 which made each ASGI request run in a fresh contextvars.Context to work around python/cpython#140947. The workaround broke valid use cases: context set in the lifespan or by external instrumentation (e.g. OpenTelemetry eBPF context propagation) is hidden from ASGI handlers. A follow-up PR will reintroduce the behavior as an opt-in flag.
Contributor
|
📖 Docs preview: https://8405f61d.uvicorn.pages.dev |
Merging this PR will degrade performance by 11.23%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_bench_fragmented_body[httptools] |
2.2 ms | 2.4 ms | -11.23% |
Comparing revert-2742 (551589f) with main (850d926)
This was referenced Apr 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2742 and #2859, which made each ASGI request run in a fresh
contextvars.Contextto work around python/cpython#140947.The workaround broke valid use cases that the original discussion did not anticipate:
asynciobug, not a uvicorn bug. gh-140947: fix contextvars handling for server tasks in asyncio python/cpython#141158 is expected to fix it upstream for Python >=3.15.A follow-up PR will reintroduce the behavior as an opt-in flag so users who rely on the isolation can still get it.
Test plan
uv run ruff check .uv run ruff format --check .uv run mypy uvicornuv run pytest tests/test_server.py tests/protocols/test_http.pyAI Disclaimer
This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.