Skip to content

Commit fa67438

Browse files
virtio-msg: clarify bus ownership of token and response association (Manos Pitsidianakis)
Manos Pitsidianakis questioned whether the ordering text around repeated request parameters in responses should be normative. Clarify instead that request/response association is the responsibility of the bus, that the token field is bus-owned and may be used for correlation or to compensate for transport-specific reordering, and that repeated request parameters in response payloads may be used for validation without affecting response association. Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
1 parent c76ec38 commit fa67438

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

transport-msg.tex

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -543,9 +543,10 @@ \subsubsection{Common Message Format}
543543
\ref{sec:Virtio Transport Options / Virtio Over Messages / Transport Messages}
544544
and
545545
\ref{sec:Virtio Transport Options / Virtio Over Messages / Bus Messages}.
546-
\item \field{token}: Correlation identifier managed by the bus. Drivers and
547-
devices treat this field as opaque; the bus MAY overwrite it to track
548-
outstanding requests or maintain ordering.
546+
\item \field{token}: Correlation identifier owned and managed by the bus.
547+
Drivers and devices treat this field as opaque. A bus implementation MAY
548+
insert or overwrite \field{token} values to correlate requests and
549+
responses or to compensate for transport-specific reordering.
549550
\item \field{msg_size}: Total size in bytes of the complete message (header
550551
plus payload).
551552
\item \field{reserved}: Reserved for future use. Transmitters set this field
@@ -606,6 +607,9 @@ \subsubsection{Common Message Format}
606607
\item A bus implementation owns the \field{token} field; it MAY insert or
607608
overwrite values for correlation purposes and MUST ensure that any such
608609
use is transparent to drivers and devices.
610+
\item A bus implementation MUST ensure that any use of \field{token} for
611+
request/response correlation or to compensate for transport-specific
612+
reordering remains transparent to drivers and devices.
609613
\end{itemize}
610614

611615
A message originator MUST transmit reserved header bits and unspecified header
@@ -628,8 +632,9 @@ \subsubsection{Message Ordering}
628632
traffic. Ordering is defined per device number; messages for different device
629633
numbers MAY be interleaved by the bus.
630634
Some response payloads repeat request parameters (for example, indices or
631-
offsets) to support validation; these repeats are informational and do not
632-
alter the correlation model described here.
635+
offsets). Drivers and devices MAY use these repeated values for validation,
636+
but request/response association is determined by the bus according to the
637+
ordering rules described here, not by those repeated values.
633638

634639
\busnormative{\paragraph}{Message Ordering}{Virtio Transport Options / Virtio Over Messages / Basic Concepts / Ordering / Bus}
635640
\begin{itemize}

0 commit comments

Comments
 (0)