tc6-regs: fix narrowing conversions in init#73
Open
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Open
tc6-regs: fix narrowing conversions in init#73tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
tkummermehr wants to merge 1 commit intoMicrochipTech:mainfrom
Conversation
Fixes clang-tidy bugprone-narrowing-conversions warnings where int16_t operands were being promoted to int during arithmetic, then narrowed back to int16_t on assignment. Casting the initOffset operands to int16_t before addition keeps arithmetic in the target type. Finding: clang-tidy/bugprone-narrowing-conversions at libtc6/src/tc6-regs.c:591,594,603,612,615,624,627,637,640
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cast initOffset operands to int16_t before arithmetic in config parameter initialization. Fixes 8 clang-tidy bugprone-narrowing-conversions warnings.
Test plan