feat(policy): add incremental sandbox policy updates#860
Draft
johntmyers wants to merge 2 commits intomainfrom
Draft
feat(policy): add incremental sandbox policy updates#860johntmyers wants to merge 2 commits intomainfrom
johntmyers wants to merge 2 commits intomainfrom
Conversation
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-860.docs.buildwithfern.com/openshell |
Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a first-pass incremental sandbox policy update workflow for OS-81 / #825.
The CLI now supports batched
openshell policy updateoperations, the server applies them atomically as one merge batch with optimistic retry on version conflicts, and the policy/docs/agent surfaces are updated to teach the new flow.Related Issue
Closes #825
Linear: OS-81
Changes
openshell-policyfor additive/removal operations onnetwork_policiesmerge_operationstoUpdateConfigRequestand implemented the server-side incremental update path with optimistic concurrency retryopenshell policy updatewith strict parsing/validation for--add-endpoint,--add-allow,--add-deny,--remove-endpoint, and related flags--add-allowand--add-denyREST-specific in this first passopenshell-cliskill/reference to prefer incremental updates for additive network changesTesting
Ran targeted verification:
RUSTC_WRAPPER= cargo check -p openshell-cliRUSTC_WRAPPER= cargo check -p openshell-serverRUSTC_WRAPPER= cargo test -p openshell-policyRUSTC_WRAPPER= cargo test -p openshell-server concurrent_merge_batches_preserve_both_updatesBINDGEN_EXTRA_CLANG_ARGS='-I/opt/homebrew/include' LIBRARY_PATH=/opt/homebrew/lib RUSTC_WRAPPER= cargo test -p openshell-cli --no-runmise run pre-commitpassesmise run pre-commitis currently blocked locally by unrelated untracked files underarchitecture/plans/that fail SPDX header checks. WithoutLIBRARY_PATH=/opt/homebrew/lib, the workspace Rust test step also hits the localz3linker path issue on this machine.Checklist