Conversation
eggplants
force-pushed
the
uv
branch
4 times, most recently
from
a4fe800 to
49a6899
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request migrates the project from Poetry to uv as the build and publish tool and introduces a Dev Container for development.
- Replaces Poetry configuration with uv/hatchling in pyproject.toml
- Updates publish.py to invoke uv commands instead of Poetry’s
- Modifies GitHub workflows and pre-commit configuration to reflect the toolchain change
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_cli.py | Reformats the assertion for better multi-line readability |
| pyproject.toml | Updates the build system and dependency groups to use hatchling and uv |
| publish.py | Switches build/publish commands from Poetry to uv and adjusts formatting |
| openapi_generator_cli/init.py | Adjusts formatting without functional changes |
| DEVELOPMENT.md | Updates setup instructions to reference the Dev Container |
| .pre-commit-config.yaml | Removes Poetry hooks, retains relevant linting hooks |
| .github/workflows/test.yaml | Replaces Poetry setup with uv setup and commands |
| .github/workflows/publish.yaml | Updates publish commands to use uv and new environment variables |
| .github/dependabot.yml | Changes package-ecosystem from pip to uv |
Files not reviewed (2)
- .devcontainer/devcontainer.json: Language not supported
- .devcontainer/postCreateCommand.sh: Language not supported
Comments suppressed due to low confidence (2)
publish.py:54
- The explicit close() call is redundant when using a context manager. Please remove it to simplify the code.
openapi_generator_jar.close()
.github/dependabot.yml:3
- Verify that 'uv' is a supported package ecosystem for Dependabot updates, as this change may affect dependency monitoring.
+- package-ecosystem: uv
Member
|
nice. let's give it a try |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have migrated Poetry to uv and introduced Dev Container.