Add HasCharSet method for ComplexPropertyBuilder#1984
Merged
lauxjpn merged 4 commits intoPomeloFoundation:mainfrom Mar 18, 2025
Merged
Add HasCharSet method for ComplexPropertyBuilder#1984lauxjpn merged 4 commits intoPomeloFoundation:mainfrom
lauxjpn merged 4 commits intoPomeloFoundation:mainfrom
Conversation
Collaborator
|
Yes, adding A current workaround should be to just specify a collation instead of a charset (which is more precise anyway). |
368f9d1 to
dc482ac
Compare
lauxjpn
requested changes
Mar 8, 2025
cf81792 to
19a749c
Compare
lauxjpn
requested changes
Mar 10, 2025
Collaborator
lauxjpn
left a comment
There was a problem hiding this comment.
Just a little cleanup, otherwise it looks good!
19a749c to
1ac8871
Compare
Collaborator
|
@trejjam Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this aims to fix an invalid snapshot generated when setting the charset on a
ComplexPropertyproperty.