Updates per platform modules updates#38
Open
bunkerdives wants to merge 1 commit intoPopMedNet-Team:2019.10from
Open
Updates per platform modules updates#38bunkerdives wants to merge 1 commit intoPopMedNet-Team:2019.10from
bunkerdives wants to merge 1 commit intoPopMedNet-Team:2019.10from
Conversation
bunkerdives
commented
Jan 18, 2020
bunkerdives
commented
- this DataRegionSelection.getSelected method no longer takes two booleans, since the 'mergeSession' parameter was eliminated in the platform modules' Pull #406
- the override of getSchema should now be one of createSchema, per Issue #38951 in the platform modules repo commit SHA e21cb
- simply removing the true parameter is fine, since the method was modified to behave as such anyhow
- this DataRegionSelection.getSelected method no longer takes two booleans, since the 'mergeSession' parameter was eliminated in the platform modules' Pull #406 - the override of getSchema should now be one of createSchema, per Issue #38951 in the platform modules repo commit SHA e21cb - simply removing the true parameter is fine, since the method was modified to behave as such anyhow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.