misc: rp1: Fix an error handling path in rp1_probe()

tititiou36 · gregkh · commit 43cd4b634ef9 · 2025-11-26T15:09:49.000+01:00
When DT is used to get the reference of 'rp1_node', it should be released when not needed anymore, otherwise it is leaking. In such a case, add the missing of_node_put() call at the end of the probe, as already done in the error handling path. Fixes: 49d6397 ("misc: rp1: RaspberryPi RP1 misc driver") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Andrea della Porta <andrea.porta@suse.com> Link: https://patch.msgid.link/9bc1206de787fa86384f3e5ba0a8027947bc00ff.1762585959.git.christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/misc/rp1/rp1_pci.c b/drivers/misc/rp1/rp1_pci.c
@@ -289,6 +289,9 @@ static int rp1_probe(struct pci_dev *pdev, const struct pci_device_id *id)
 		goto err_unload_overlay;
 	}
 
+	if (skip_ovl)
+		of_node_put(rp1_node);
+
 	return 0;
 
 err_unload_overlay:

Original file line number	Diff line number	Diff line change
`@@ -289,6 +289,9 @@ static int rp1_probe(struct pci_dev pdev, const struct pci_device_id id)`
`289`	`289`	`goto err_unload_overlay;`
`290`	`290`	`}`
`291`	`291`
	`292`	`+ if (skip_ovl)`
	`293`	`+ of_node_put(rp1_node);`
	`294`	`+`
`292`	`295`	`return 0;`
`293`	`296`
`294`	`297`	`err_unload_overlay:`