Skip to content

Commit 85e8378

Browse files
DispatchCodegregkh
authored andcommitted
char: xillybus: add WQ_UNBOUND to alloc_workqueue users
Currently if a user enqueues a work item using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to schedule_work() that is using system_wq and queue_work(), that makes use again of WORK_CPU_UNBOUND. This lack of consistency cannot be addressed without refactoring the API. alloc_workqueue() treats all queues as per-CPU by default, while unbound workqueues must opt-in via WQ_UNBOUND. This default is suboptimal: most workloads benefit from unbound queues, allowing the scheduler to place worker threads where they’re needed and reducing noise when CPUs are isolated. This continues the effort to refactor workqueue APIs, which began with the introduction of new workqueues and a new alloc_workqueue flag in: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") This change adds the WQ_UNBOUND flag to explicitly request alloc_workqueue() to be unbound, because this specific workload has no benefit being per-cpu. With the introduction of the WQ_PERCPU flag (equivalent to !WQ_UNBOUND), any alloc_workqueue() caller that doesn’t explicitly specify WQ_UNBOUND must now use WQ_PERCPU. Once migration is complete, WQ_UNBOUND can be removed and unbound will become the implicit default. Suggested-by: Tejun Heo <tj@kernel.org> Signed-off-by: Marco Crivellari <marco.crivellari@suse.com> Acked-by: Eli Billauer <eli.billauer@gmail.com> Link: https://patch.msgid.link/20251107163755.356187-1-marco.crivellari@suse.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ef48f0f commit 85e8378

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/char/xillybus/xillybus_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1973,7 +1973,7 @@ EXPORT_SYMBOL(xillybus_endpoint_remove);
19731973

19741974
static int __init xillybus_init(void)
19751975
{
1976-
xillybus_wq = alloc_workqueue(xillyname, 0, 0);
1976+
xillybus_wq = alloc_workqueue(xillyname, WQ_UNBOUND, 0);
19771977
if (!xillybus_wq)
19781978
return -ENOMEM;
19791979

drivers/char/xillybus/xillyusb.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2163,7 +2163,7 @@ static int xillyusb_probe(struct usb_interface *interface,
21632163
spin_lock_init(&xdev->error_lock);
21642164
xdev->in_counter = 0;
21652165
xdev->in_bytes_left = 0;
2166-
xdev->workq = alloc_workqueue(xillyname, WQ_HIGHPRI, 0);
2166+
xdev->workq = alloc_workqueue(xillyname, WQ_HIGHPRI | WQ_UNBOUND, 0);
21672167

21682168
if (!xdev->workq) {
21692169
dev_err(&interface->dev, "Failed to allocate work queue\n");
@@ -2275,7 +2275,7 @@ static int __init xillyusb_init(void)
22752275
{
22762276
int rc = 0;
22772277

2278-
wakeup_wq = alloc_workqueue(xillyname, 0, 0);
2278+
wakeup_wq = alloc_workqueue(xillyname, WQ_UNBOUND, 0);
22792279
if (!wakeup_wq)
22802280
return -ENOMEM;
22812281

0 commit comments

Comments
 (0)