Skip to content

Commit ef48f0f

Browse files
Vivek BalachandharTNgregkh
authored andcommitted
misc: bh1770glc: use pm_runtime_resume_and_get() in power_state_store
pm_runtime_get_sync() may increment the runtime PM usage count even if the resume fails, which requires an explicit pm_runtime_put_noidle() to balance it. This driver ignored the return value, risking a usage-count leak on resume failure. Replace it with pm_runtime_resume_and_get(), which returns 0 on success and a negative errno on failure, and only increments the usage count on success. This simplifies the error path and avoids possible leaks. Also check for errors explicitly with `if (ret < 0)`. Signed-off-by: Vivek BalachandharTN <vivek.balachandhar@gmail.com> Link: https://patch.msgid.link/20251030120022.239951-1-vivek.balachandhar@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 05d36a5 commit ef48f0f

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/misc/bh1770glc.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,9 @@ static ssize_t bh1770_power_state_store(struct device *dev,
640640

641641
mutex_lock(&chip->mutex);
642642
if (value) {
643-
pm_runtime_get_sync(dev);
643+
ret = pm_runtime_resume_and_get(dev);
644+
if (ret < 0)
645+
goto leave;
644646

645647
ret = bh1770_lux_rate(chip, chip->lux_rate_index);
646648
if (ret < 0) {

0 commit comments

Comments
 (0)