Skip to content

[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes.#8673

Open
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr8611-to-sssd-2-10
Open

[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes.#8673
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
sssd-bot:SSSD-sssd-backport-pr8611-to-sssd-2-10

Conversation

@sssd-bot
Copy link
Copy Markdown
Contributor

@sssd-bot sssd-bot commented May 5, 2026

This is an automatic backport of PR#8611 refactoring ipa tests for hostname framework changes. to branch sssd-2-10, created by @danlavu.

Caution

@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with CONFLICT!.

You can push changes to this pull request

git remote add sssd-bot git@github.com:sssd-bot/sssd.git
git fetch sssd-bot refs/heads/SSSD-sssd-backport-pr8611-to-sssd-2-10
git checkout SSSD-sssd-backport-pr8611-to-sssd-2-10
git push sssd-bot SSSD-sssd-backport-pr8611-to-sssd-2-10 --force

Original commits
8f170d0 - refactoring ipa tests for hostname framework changes.

Backported commits

  • 23a2ac3 - CONFLICT! refactoring ipa tests for hostname framework changes.

Conflicting Files Information (check for deleted and re-added files)

  • CONFLICT! refactoring ipa tests for hostname framework changes.
On branch SSSD-sssd-backport-pr8611-to-sssd-2-10
You are currently cherry-picking commit 8f170d08a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   src/tests/system/tests/test_ipa.py

no changes added to commit (use "git add" and/or "git commit -a")

Original Pull Request Body

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors IPA system tests to utilize the hostname framework, replacing hardcoded hostnames with dynamic references across various test cases. It also introduces a new test for verifying ID view overrides during email lookups. A critical issue was identified where unresolved Git conflict markers were left in the code, which will cause a syntax error during execution.

Comment thread src/tests/system/tests/test_ipa.py Outdated
Comment thread src/tests/system/tests/test_ipa.py Fixed
Reviewed-by: Jakub Vávra <jvavra@redhat.com>
Reviewed-by: Justin Stephenson <jstephen@redhat.com>
Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com>
(cherry picked from commit 8f170d0)
@danlavu danlavu force-pushed the SSSD-sssd-backport-pr8611-to-sssd-2-10 branch from 23a2ac3 to 721f7c6 Compare May 6, 2026 22:01
@danlavu danlavu marked this pull request as ready for review May 6, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants