[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes.#8673
Open
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
Open
[autobackport: sssd-2-10] refactoring ipa tests for hostname framework changes.#8673sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
sssd-bot wants to merge 1 commit intoSSSD:sssd-2-10from
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors IPA system tests to utilize the hostname framework, replacing hardcoded hostnames with dynamic references across various test cases. It also introduces a new test for verifying ID view overrides during email lookups. A critical issue was identified where unresolved Git conflict markers were left in the code, which will cause a syntax error during execution.
Reviewed-by: Jakub Vávra <jvavra@redhat.com> Reviewed-by: Justin Stephenson <jstephen@redhat.com> Reviewed-by: Madhuri Upadhye <mupadhye@redhat.com> (cherry picked from commit 8f170d0)
23a2ac3 to
721f7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of PR#8611 refactoring ipa tests for hostname framework changes. to branch sssd-2-10, created by @danlavu.
Caution
@danlavu The patches did not apply cleanly. It is necessary to resolve conflicts before merging this pull request. Commits that introduced conflict are marked with
CONFLICT!.You can push changes to this pull request
Original commits
8f170d0 - refactoring ipa tests for hostname framework changes.
Backported commits
Conflicting Files Information (check for deleted and re-added files)
Original Pull Request Body