Translations update from Fedora Weblate#8684
Conversation
Added translation using Weblate (Romanian) Update translation files Updated by "Update LINGUAS file" hook in Weblate. Translation: SSSD/sssd-1-16 Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-1-16/ Added translation using Weblate (Chinese (Traditional) (zh_TW)) Added translation using Weblate (Turkish) Added translation using Weblate (Polish) Added translation using Weblate (Norwegian Bokmål) Added translation using Weblate (Korean) Added translation using Weblate (Georgian) Added translation using Weblate (Italian) Added translation using Weblate (Indonesian) Added translation using Weblate (Hungarian) Added translation using Weblate (Bulgarian) Added translation using Weblate (Latvian) Added translation using Weblate (Korean) Added translation using Weblate (Georgian) Added translation using Weblate (Finnish) Added translation using Weblate (Breton)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for several new languages (ka, ko, fi, lv, br, ro) by updating the LINGUAS file and adding the corresponding .po files. The review identified that the LINGUAS file entries should be sorted alphabetically and that the plural forms header for the Georgian (ka) translation is incorrect, which could cause issues for future translations.
| ka | ||
| ko | ||
| fi | ||
| lv | ||
| br | ||
| ro |
There was a problem hiding this comment.
The added languages are not alphabetically sorted and are preceded by an empty line (line 24). This can lead to inconsistencies in build scripts that parse this file and makes it harder to maintain. Additionally, all the added .po files are currently 100% untranslated (all msgstr entries are empty). It is recommended to remove the empty line, sort the entries, and consider whether empty translation files should be enabled in the build process at this stage, as they result in the installation of empty message catalogs.
br
fi
ka
ko
lv
ro
| "MIME-Version: 1.0\n" | ||
| "Content-Type: text/plain; charset=UTF-8\n" | ||
| "Content-Transfer-Encoding: 8bit\n" | ||
| "Plural-Forms: nplurals=2; plural=n != 1;\n" |
There was a problem hiding this comment.
The plural forms header for Georgian (ka) is incorrect. Georgian typically uses a single plural form for all numbers in the context of UI translations (nouns do not change form after numbers). Using nplurals=2 is inconsistent with standard practice for this language in gettext and will cause issues for future translators.
"Plural-Forms: nplurals=1; plural=0;\n"
1 participant
Translations update from Fedora Weblate for SSSD/sssd-1-16.
Current translation status: