Fix v7: second eachindex(sol) in dense_tests, EEst→set_EEst! in TSRKC3#3457
Merged
ChrisRackauckas merged 1 commit intoSciML:v7from Apr 16, 2026
Merged
Conversation
- test/regression/ode_dense_tests.jl line 69: second `eachindex(sol2)` instance (1D linear problem loop) that was missed by SciML#3446. Same RAT v4 issue — `eachindex(sol)` now returns CartesianIndices, use `eachindex(sol2.u)` for the per-timestep iteration. - lib/OrdinaryDiffEqStabilizedRK/src/rkc_perform_step.jl lines 1191 and 1323: `integrator.EEst = ...` throws `FieldError` since SciML#3422 moved EEst from the integrator struct to the controller cache. Replace with `OrdinaryDiffEqCore.set_EEst!(integrator, ...)` matching every other sublibrary. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Apr 20, 2026
…3457) - test/regression/ode_dense_tests.jl line 69: second `eachindex(sol2)` instance (1D linear problem loop) that was missed by #3446. Same RAT v4 issue — `eachindex(sol)` now returns CartesianIndices, use `eachindex(sol2.u)` for the per-timestep iteration. - lib/OrdinaryDiffEqStabilizedRK/src/rkc_perform_step.jl lines 1191 and 1323: `integrator.EEst = ...` throws `FieldError` since #3422 moved EEst from the integrator struct to the controller cache. Replace with `OrdinaryDiffEqCore.set_EEst!(integrator, ...)` matching every other sublibrary. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ChrisRackauckas
added a commit
that referenced
this pull request
Apr 21, 2026
…3457) - test/regression/ode_dense_tests.jl line 69: second `eachindex(sol2)` instance (1D linear problem loop) that was missed by #3446. Same RAT v4 issue — `eachindex(sol)` now returns CartesianIndices, use `eachindex(sol2.u)` for the per-timestep iteration. - lib/OrdinaryDiffEqStabilizedRK/src/rkc_perform_step.jl lines 1191 and 1323: `integrator.EEst = ...` throws `FieldError` since #3422 moved EEst from the integrator struct to the controller cache. Replace with `OrdinaryDiffEqCore.set_EEst!(integrator, ...)` matching every other sublibrary. Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two real test failures on the current v7 CI (PR #3242, SHA
428db4a89d):Regression_I — Dense Tests (line 69)
#3446 fixed
eachindex(sol2)→eachindex(sol2.u)at line 118 (2D problem loop) but missed the same pattern at line 69 (1D linear problem loop). Same RAT v4 issue:eachindex(sol)returnsCartesianIndicesinstead of1:nsteps.Regression_II — TSRKC3 FieldError
perform_step!for TSRKC3 atrkc_perform_step.jl:1191and:1323writesintegrator.EEst = ..., but #3422 movedEEstfrom the integrator struct to the controller cache. Every other sublibrary usesOrdinaryDiffEqCore.set_EEst!(integrator, ...)— these two sites were missed.Other failures on this run
🤖 Generated with Claude Code