Open
Conversation
Restoring Stefan Gräber's original suggestion of #1602: Only configuring the line endings of Java files in 0ce7916 was actually not enough as the build itself modifies them using `archunit.header.template`, which needs to use LF line endings as well. Signed-off-by: Manfred Hanke <Manfred.Hanke@tngtech.com>
hankem
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring @StefanGraeber's original suggestion of #1602:
Only configuring the line endings of Java files in 0ce7916 was actually not enough as the build itself modifies them using
archunit.header.template, which needs to use LF line endings as well.(I merged #1602 despite spotless failures on Windows, as it seemed plausible that these were caused by
.gitattributessettings only applying when git writes files to the working tree – not when switching the branch; a behavior I had observed locally. Therefore, I assumed that the CI build for #1602 might still have used the line endings frommain, and that the failure would heal itself once the.gitattributesare onmain. However, that assumption turned out to be incorrect. 🙈)