Merge branch 'master' of https://github.com/The-OpenROAD-Project-private/OpenROAD into secure-jhkim-test

Author: jhkim-pii

src/dft/test/BUILD

@@ -62,8 +62,6 @@ filegroup(
         "register_bank_cores.lef",
         "register_bank_top.v",
         "scan_architect_sky130.v",
-        "scan_inserted_design_sky130.def.ok",
-        "scan_inserted_design_sky130.out.def",
         "scan_inserted_design_sky130.scandef",
         "scan_inserted_design_sky130.v",
         "scan_inserted_register_bank.v",

src/dft/test/save_defok.sh

@@ -0,0 +1 @@
+../../../test/shared/save_defok.sh

src/dft/test/scan_inserted_design_sky130.out.def

@@ -8,5 +8,6 @@ read_verilog scan_inserted_design_sky130.v
 link_design scan_inserted_design
 
 read_def -incremental scan_inserted_design_sky130.scandef
-write_def scan_inserted_design_sky130.out.def
-diff_files scan_inserted_design_sky130.out.def scan_inserted_design_sky130.def.ok
+set result_def [make_result_file scandef_sky130.def]
+write_def $result_def
+diff_files $result_def "scandef_sky130.defok"

…/test/scan_inserted_design_sky130.def.ok src/dft/test/scandef_sky130.defoksrc/dft/test/scan_inserted_design_sky130.def.ok renamed to src/dft/test/scandef_sky130.defok src/dft/test/scan_inserted_design_sky130.def.ok renamed to src/dft/test/scandef_sky130.defok

@@ -3785,7 +3785,7 @@ void FlexGCWorker::Impl::patchMetalShape_cornerSpacing()
   }
 }
 
-// loop through violation and patch C5 enclosure minStep for GF14
+// Patch minStep markers for transition layers vias
 void FlexGCWorker::Impl::patchMetalShape_minStep()
 {
   std::vector<drConnFig*> results;
@@ -3801,7 +3801,8 @@ void FlexGCWorker::Impl::patchMetalShape_minStep()
     auto layer = tech_->getLayer(lNum);
     if (!layer->hasVia2ViaMinStepViol()
         && !tech_->getLayer(lNum - 1)->hasLef58MaxSpacingConstraints()
-        && !tech_->getLayer(lNum + 1)->hasLef58MaxSpacingConstraints()) {
+        && (lNum + 1 >= tech_->getLayers().size()
+            || !tech_->getLayer(lNum + 1)->hasLef58MaxSpacingConstraints())) {
       continue;
     }
 

src/dft/test/scandef_sky130.tcl

@@ -288,6 +288,8 @@ class GlobalRouter
   FastRouteCore* fastroute() const { return fastroute_; }
   Rudy* getRudy();
 
+  void writePinLocations(const char* file_name);
+
  private:
   // Net functions
   Net* addNet(odb::dbNet* db_net);

src/drt/src/gc/FlexGC_main.cpp

@@ -4782,6 +4782,29 @@ std::vector<PinGridLocation> GlobalRouter::getPinGridPositions(
   return pin_locs;
 }
 
+void GlobalRouter::writePinLocations(const char* file_name)
+{
+  std::ofstream pin_loc_file;
+  pin_loc_file.open(file_name);
+  if (!pin_loc_file) {
+    logger_->error(
+        GRT, 271, "Global route pin locations file could not be opened.");
+  }
+
+  for (const auto [db_net, net] : db_net_map_) {
+    if (!net->getPins().empty()) {
+      pin_loc_file << net->getName() << " " << net->getNumPins() << "\n";
+      for (const Pin& pin : net->getPins()) {
+        const odb::Point& pin_pos = pin.getOnGridPosition();
+        pin_loc_file << pin.getName() << " " << pin_pos.getX() << " "
+                     << pin_pos.getY() << "\n";
+      }
+      pin_loc_file << "\n";
+    }
+  }
+  pin_loc_file.close();
+}
+
 ////////////////////////////////////////////////////////////////
 
 bool operator<(const RoutePt& p1, const RoutePt& p2)

src/grt/include/grt/GlobalRouter.h

@@ -252,6 +252,11 @@ void read_segments(const char* file_name)
   getGlobalRouter()->readSegments(file_name);
 }
 
+void write_pin_locations(const char* file_name)
+{
+  getGlobalRouter()->writePinLocations(file_name);
+}
+
 } // namespace
 
 %} // inline

src/grt/src/GlobalRouter.cpp

@@ -62,14 +62,28 @@ The `WORK_HOME` is in `/tmp/place/_main`:
     Archiving issue to global_place_skip_io_Element_asap7_base_2025-07-16_08-44.tar.gz
     Using pigz to compress tar file
 
-To use a local ORFS and OpenROAD built by CMake:
+## Using a local ORFS
+
+bazel-orfs can set up ORFS design files locally for debugging purposes, leaving bazel-orfs entirely out of the equation when chasing down issues. Such a setup is most often a lot more convenient than using `--sandbox_debug`.
+
+NOTE! keep in mind that these local ORFS design files have the depndencies `_deps` to run a particular stage only. Hence, use the `do-` prefix for doing `do-place`, `do-2_1_floorplan`, etc. so that `make` dependency checking is not used. If you use `make floorplan`, this will try to run synthesis first and not find the prequisite files, nor variables in config.mk, for synthesis and it will fail with bogus and confusing error messages.
+
+If you're interested in some other stage, replace `place` with `synth`, `floorplan`, `cts`, `grt`, `route` or `final` below.
+
+The `/tmp/place/make` script, if `FLOW_HOME` is set, will use a local ORFS and OpenROAD built by CMake:
 
     $ . ~/OpenROAD-flow-scripts/env.sh
     $ /tmp/place/make print-FLOW_HOME print-OPENROAD_EXE
     [deleted]
     FLOW_HOME = /home/<username>/OpenROAD-flow-scripts/flow
     OPENROAD_EXE = /home/<username>/OpenROAD-flow-scripts/tools/install/OpenROAD/bin/openroad
 
+More explictly ORFS only:
+
+    make --file=~/OpenROAD-flow-scripts/flow/Makefile -C /tmp/place/_main WORK_HOME=test/orfs/mock-array DESIGN_CONFIG=config.mk do-place
+
+This is a bit more verbose, but eliminates any concerns about what the `/tmp/place/make` might be doing differently than ORFS only.
+
 ## Running a `make issue` with `cfg=exec` configuraiton
 
 [TL;DR](../../docs/user/Bazel-targets.md), `bazelisk test ...` builds and uses the `cfg=exec` configuration when setting up paths: