Skip to content
Open
Show file tree
Hide file tree
Changes from 12 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Removed 32-bit compilation check for HID on Windows players, which had no impact anymore. (ISX-2543)
- Migrated sample scenes to use Universal Render Pipeline (URP) with Built-in Render Pipeline fallback shaders. The URP package is now required to run the samples. (ISX-2343)
- Changed the UI for `Actions.inputactions` asset to use UI Toolkit framework.
- Changed the UI for `InputSystem.inputsettings` asset to use UI Toolkit framework.

### Added

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using System;
using System.IO;
using UnityEditor;
using UnityEngine.UIElements;

namespace UnityEngine.InputSystem.Editor
{
Expand All @@ -19,7 +20,7 @@
InvalidPath,

/// <summary>
/// The dialog was cancelled by the user and the path is invalid.
/// The dialog was canceled by the user and the path is invalid.
Comment thread
josepmariapujol-unity marked this conversation as resolved.
Comment thread
josepmariapujol-unity marked this conversation as resolved.
/// </summary>
Cancelled,

Expand Down Expand Up @@ -82,12 +83,22 @@
return asset;
}

public static void DrawMakeActiveGui<T>(T current, T target, string targetName, string entity, Action<T> apply, bool allowAssignActive = true)
public static VisualElement CreateMakeActiveGui<T>(T current, T target, string targetName, string entity, Action<T> apply, bool allowAssignActive = true)
Comment thread
josepmariapujol-unity marked this conversation as resolved.
Outdated
Comment thread
josepmariapujol-unity marked this conversation as resolved.
Outdated
where T : ScriptableObject
{
var container = new VisualElement();
PopulateMakeActiveGui(container, current, target, entity, apply, allowAssignActive);
return container;
}

Check warning on line 92 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L89-L92

Added lines #L89 - L92 were not covered by tests

private static void PopulateMakeActiveGui<T>(VisualElement container, T current, T target, string entity, Action<T> apply, bool allowAssignActive)
Comment thread
josepmariapujol-unity marked this conversation as resolved.
where T : ScriptableObject
{
container.Clear();

Check warning on line 97 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L96-L97

Added lines #L96 - L97 were not covered by tests

if (current == target)
{
EditorGUILayout.HelpBox($"These actions are assigned as the {entity}.", MessageType.Info);
container.Add(new HelpBox($"These actions are assigned as the {entity}.", HelpBoxMessageType.Info));

Check warning on line 101 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L101

Added line #L101 was not covered by tests
Comment thread
josepmariapujol-unity marked this conversation as resolved.
return;
}

Expand All @@ -96,11 +107,21 @@
currentlyActiveAssetsPath = AssetDatabase.GetAssetPath(current);
if (!string.IsNullOrEmpty(currentlyActiveAssetsPath))
currentlyActiveAssetsPath = $" The actions currently assigned as the {entity} are: {currentlyActiveAssetsPath}. ";
EditorGUILayout.HelpBox($"These actions are not assigned as the {entity} for the Input System. {currentlyActiveAssetsPath??""}", MessageType.Warning);
GUI.enabled = allowAssignActive;
if (GUILayout.Button($"Assign as the {entity}", EditorStyles.miniButton))

container.Add(new HelpBox(

Check warning on line 111 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L111

Added line #L111 was not covered by tests
Comment thread
josepmariapujol-unity marked this conversation as resolved.
$"These actions are not assigned as the {entity} for the Input System. {currentlyActiveAssetsPath ?? ""}",
Comment thread
josepmariapujol-unity marked this conversation as resolved.
HelpBoxMessageType.Warning));

var assignButton = new Button(() =>
{

Check warning on line 116 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L115-L116

Added lines #L115 - L116 were not covered by tests
apply(target);
GUI.enabled = true;
PopulateMakeActiveGui(container, target, target, entity, apply, allowAssignActive);
})

Check warning on line 119 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L118-L119

Added lines #L118 - L119 were not covered by tests
{
text = $"Assign as the {entity}"
};
assignButton.SetEnabled(allowAssignActive);
container.Add(assignButton);

Check warning on line 124 in Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/InputAssetEditorUtils.cs#L123-L124

Added lines #L123 - L124 were not covered by tests
}

public static bool IsValidFileExtension(string path)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -489,17 +489,21 @@
[CustomEditor(typeof(InputSettings))]
internal class InputSettingsEditor : UnityEditor.Editor
{
public override void OnInspectorGUI()
public override VisualElement CreateInspectorGUI()
{
EditorGUILayout.Space();
var root = new VisualElement();

Check warning on line 494 in Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs#L494

Added line #L494 was not covered by tests

if (GUILayout.Button("Open Input Settings Window", GUILayout.Height(30)))
InputSettingsProvider.Open();
var openButton = new Button(() => InputSettingsProvider.Open())

Check warning on line 496 in Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs#L496

Added line #L496 was not covered by tests
{
text = "Open Input Settings Window",
style = { minHeight = 30, whiteSpace = WhiteSpace.Normal }
};
root.Add(openButton);

Check warning on line 501 in Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs#L501

Added line #L501 was not covered by tests

EditorGUILayout.Space();
root.Add(InputAssetEditorUtils.CreateMakeActiveGui(InputSystem.settings, target as InputSettings,
target.name, "settings", (value) => InputSystem.settings = value));

Check warning on line 504 in Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs#L503-L504

Added lines #L503 - L504 were not covered by tests

InputAssetEditorUtils.DrawMakeActiveGui(InputSystem.settings, target as InputSettings,
target.name, "settings", (value) => InputSystem.settings = value);
return root;

Check warning on line 506 in Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs

View check run for this annotation

Codecov GitHub.com / codecov/patch

Packages/com.unity.inputsystem/InputSystem/Editor/Settings/InputSettingsProvider.cs#L506

Added line #L506 was not covered by tests
}

protected override bool ShouldHideOpenButton()
Expand Down
Loading