🧪 Add tests for GraphQLResponse.data fallback and missing coverage

[abn]

🎯 What: The testing gap addressed is the edge case in GraphQLResponse.data when the json is initialized with {'data': None}. Due to the way isinstance(None, dict) evaluates to False, the property gracefully falls back to returning an empty dictionary {}, but this behavior lacked explicitly targeted tests.

📊 Coverage: The following scenarios are now additionally tested:

• GraphQLResponse.data returning {} when {'data': None} is provided in JSON.
• GraphQLResponse.errors returning [] when {'errors': None} or no 'errors' key is present.
• GraphQLResponse.query evaluating correctly when initialized with a true GraphQLRequest object instead of a string.
• GraphQLResponse.data_as functioning correctly when extracting to a dict without providing a navigation path.

✨ Result: The improvement in test coverage increases the test coverage of src/aiographql/client/response.py to a full 100%. These tests act as a safety net against regressions in how invalid or semi-valid GraphQL response payloads are handled.

---

PR created automatically by Jules for task 4022231266722643061 started by @abn

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[qodo-code-review]

Review Summary by Qodo

Add comprehensive tests for GraphQLResponse edge cases

🧪 Tests

Walkthroughs

Description

• Add tests for GraphQLResponse.data fallback when data is None
• Add tests for GraphQLResponse.errors fallback scenarios
• Add test for GraphQLResponse.query with GraphQLRequest object
• Add test for data_as() method without path parameter
• Achieve 100% test coverage for src/aiographql/client/response.py

Diagram

flowchart LR
  A["GraphQLResponse edge cases"] --> B["data fallback with None"]
  A --> C["errors fallback scenarios"]
  A --> D["query with GraphQLRequest object"]
  A --> E["data_as without path"]
  B --> F["100% coverage achieved"]
  C --> F
  D --> F
  E --> F

Loading

File Changes

1. tests/test_response.py 🧪 Tests +34/-0

Add edge case tests for GraphQLResponse properties

• Added test_graphql_response_data_fallback() to verify data returns {} when json contains
 {'data': None}
• Added test_graphql_response_errors_fallback() to test errors fallback for None and missing keys,
 plus valid error handling
• Extended test_graphql_response_coverage() with test for query property when request is a
 GraphQLRequest object
• Added test for data_as() method without path parameter to extract entire data dict

tests/test_response.py

---

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0) 📐 Spec deviations (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

ⓘ The new review experience is currently in Beta. Learn more