Add a flag for enabling pprof on the controller manager#4449
Draft
Okabe-Junya wants to merge 1 commit intoactions:masterfrom
Draft
Add a flag for enabling pprof on the controller manager#4449Okabe-Junya wants to merge 1 commit intoactions:masterfrom
Okabe-Junya wants to merge 1 commit intoactions:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cf. mercari#3
What
Add a
--pprof-addrflag to the controller manager to expose Go's built-in pprof endpoint.When the flag is set (e.g.
--pprof-addr=:6060), the controller-runtime manager starts a pprof HTTP server on the specified address. When the flag is omitted or empty, pprof remains disabled (no behavior change).The Helm chart is also updated to support configuring this via
values.yaml.Why
When operating ARC at scale, profiling the controller is essential for diagnosing memory leaks, goroutine issues, and CPU bottlenecks. controller-runtime already supports
PprofBindAddressin its manager options, but ARC does not expose it as a flag, so there is currently no way to enable pprof without modifying the source code.