Add test helper to open, select date and close the Pikaday#379
Open
lindyhopchris wants to merge 2 commits intoadopted-ember-addons:masterfrom
Open
Add test helper to open, select date and close the Pikaday#379lindyhopchris wants to merge 2 commits intoadopted-ember-addons:masterfrom
lindyhopchris wants to merge 2 commits intoadopted-ember-addons:masterfrom
Conversation
Author
|
@MelSumner see you've self-requested a review on this. would be good to get this added to the addon if possible. do you need me to fix the merge conflicts or can you do that easily? |
Contributor
|
@lindyhopchris If you could resolve the conflicts that would be great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pikaday can now be opened, a date selected, and then closed using the
fillInDatetest helper:This is equivalent to:
Closes #231