Remove pytest_plugin by Dreamsorcerer · Pull Request #10762 · aio-libs/aiohttp

Dreamsorcerer · 2025-04-20T22:36:04Z

This will be maintained exclusively in pytest-aiohttp going forwards.

codecov · 2025-04-20T22:48:19Z

❌ 1 Tests Failed:

Tests completed	Failed	Passed	Skipped
4477	1	4476	75

View the top 1 failed test(s) by shortest run time

tests.test_benchmarks_client::test_one_hundred_simple_get_requests_no_session

Stack Traces | 0.402s run time

self = <ProactorEventLoop running=False closed=True debug=False>

    #x1B[0m#x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mclose#x1B[39;49;00m(#x1B[96mself#x1B[39;49;00m):#x1B[90m#x1B[39;49;00m
    #x1B[90m    #x1B[39;49;00m#x1B[33m"""Close the event loop.#x1B[39;49;00m
    #x1B[33m#x1B[39;49;00m
    #x1B[33m    This clears the queues and shuts down the executor,#x1B[39;49;00m
    #x1B[33m    but does not wait for the executor to finish.#x1B[39;49;00m
    #x1B[33m#x1B[39;49;00m
    #x1B[33m    The event loop must not be running.#x1B[39;49;00m
    #x1B[33m    """#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        #x1B[94mif#x1B[39;49;00m #x1B[96mself#x1B[39;49;00m.is_running():#x1B[90m#x1B[39;49;00m
            #x1B[94mraise#x1B[39;49;00m #x1B[96mRuntimeError#x1B[39;49;00m(#x1B[33m"#x1B[39;49;00m#x1B[33mCannot close a running event loop#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
        #x1B[94mif#x1B[39;49;00m #x1B[96mself#x1B[39;49;00m._closed:#x1B[90m#x1B[39;49;00m
            #x1B[94mreturn#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        #x1B[94mif#x1B[39;49;00m #x1B[96mself#x1B[39;49;00m._debug:#x1B[90m#x1B[39;49;00m
            logger.debug(#x1B[33m"#x1B[39;49;00m#x1B[33mClose #x1B[39;49;00m#x1B[33m%r#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[96mself#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
        #x1B[96mself#x1B[39;49;00m._closed = #x1B[94mTrue#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
>       #x1B[96mself#x1B[39;49;00m._ready.clear()#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE       ResourceWarning: unclosed <socket.socket fd=2784, family=2, type=1, proto=0>#x1B[0m

executor   = None
self       = <ProactorEventLoop running=False closed=True debug=False>

#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\asyncio\base_events.py#x1B[0m:716: ResourceWarning

#x1B[33mThe above exception was the direct cause of the following exception:#x1B[0m

cls = <class '_pytest.runner.CallInfo'>
func = <function call_and_report.<locals>.<lambda> at 0x00000233E3D256C0>
when = 'teardown'
reraise = (<class '_pytest.outcomes.Exit'>, <class 'KeyboardInterrupt'>)

    #x1B[0m#x1B[37m@classmethod#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
    #x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mfrom_call#x1B[39;49;00m(#x1B[90m#x1B[39;49;00m
        #x1B[96mcls#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
        func: Callable[[], TResult],#x1B[90m#x1B[39;49;00m
        when: Literal[#x1B[33m"#x1B[39;49;00m#x1B[33mcollect#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33msetup#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33mcall#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m, #x1B[33m"#x1B[39;49;00m#x1B[33mteardown#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m],#x1B[90m#x1B[39;49;00m
        reraise: #x1B[96mtype#x1B[39;49;00m[#x1B[96mBaseException#x1B[39;49;00m] | #x1B[96mtuple#x1B[39;49;00m[#x1B[96mtype#x1B[39;49;00m[#x1B[96mBaseException#x1B[39;49;00m], ...] | #x1B[94mNone#x1B[39;49;00m = #x1B[94mNone#x1B[39;49;00m,#x1B[90m#x1B[39;49;00m
    ) -> CallInfo[TResult]:#x1B[90m#x1B[39;49;00m
    #x1B[90m    #x1B[39;49;00m#x1B[33m"""Call func, wrapping the result in a CallInfo.#x1B[39;49;00m
    #x1B[33m#x1B[39;49;00m
    #x1B[33m    :param func:#x1B[39;49;00m
    #x1B[33m        The function to call. Called without arguments.#x1B[39;49;00m
    #x1B[33m    :type func: Callable[[], _pytest.runner.TResult]#x1B[39;49;00m
    #x1B[33m    :param when:#x1B[39;49;00m
    #x1B[33m        The phase in which the function is called.#x1B[39;49;00m
    #x1B[33m    :param reraise:#x1B[39;49;00m
    #x1B[33m        Exception or exceptions that shall propagate if raised by the#x1B[39;49;00m
    #x1B[33m        function, instead of being wrapped in the CallInfo.#x1B[39;49;00m
    #x1B[33m    """#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        excinfo = #x1B[94mNone#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        instant = timing.Instant()#x1B[90m#x1B[39;49;00m
        #x1B[94mtry#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
>           result: TResult | #x1B[94mNone#x1B[39;49;00m = func()#x1B[90m#x1B[39;49;00m
                                     ^^^^^^#x1B[90m#x1B[39;49;00m

cls        = <class '_pytest.runner.CallInfo'>
duration   = Duration(start=Instant(time=1777911927.7851458, perf_count=892.5524179), stop=Instant(time=1777911927.8123562, perf_count=892.580509))
excinfo    = <ExceptionInfo PytestUnraisableExceptionWarning('Exception ignored in: <socket.socket fd=2784, family=2, type=1, proto...cated.\nSee https://docs.pytest..../stable/how-to/capture-warnings.html#resource-warnings for more info.') tblen=13>
func       = <function call_and_report.<locals>.<lambda> at 0x00000233E3D256C0>
instant    = Instant(time=1777911927.7851458, perf_count=892.5524179)
reraise    = (<class '_pytest.outcomes.Exit'>, <class 'KeyboardInterrupt'>)
result     = None
when       = 'teardown'

#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\runner.py#x1B[0m:353: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\runner.py#x1B[0m:245: in <lambda>
    #x1B[0m#x1B[94mlambda#x1B[39;49;00m: runtest_hook(item=item, **kwds),#x1B[90m#x1B[39;49;00m
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^#x1B[90m#x1B[39;49;00m
        item       = <Function test_one_hundred_simple_get_requests_no_session>
        kwds       = {'nextitem': <Function test_one_hundred_simple_get_requests_multiple_methods_route>}
        runtest_hook = <HookCaller 'pytest_runtest_teardown'>
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_hooks.py#x1B[0m:512: in __call__
    #x1B[0m#x1B[94mreturn#x1B[39;49;00m #x1B[96mself#x1B[39;49;00m._hookexec(#x1B[96mself#x1B[39;49;00m.name, #x1B[96mself#x1B[39;49;00m._hookimpls.copy(), kwargs, firstresult)#x1B[90m#x1B[39;49;00m
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^#x1B[90m#x1B[39;49;00m
        firstresult = False
        kwargs     = {'item': <Function test_one_hundred_simple_get_requests_no_session>, 'nextitem': <Function test_one_hundred_simple_get_requests_multiple_methods_route>}
        self       = <HookCaller 'pytest_runtest_teardown'>
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\pluggy\_manager.py#x1B[0m:120: in _hookexec
    #x1B[0m#x1B[94mreturn#x1B[39;49;00m #x1B[96mself#x1B[39;49;00m._inner_hookexec(hook_name, methods, kwargs, firstresult)#x1B[90m#x1B[39;49;00m
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^#x1B[90m#x1B[39;49;00m
        firstresult = False
        hook_name  = 'pytest_runtest_teardown'
        kwargs     = {'item': <Function test_one_hundred_simple_get_requests_no_session>, 'nextitem': <Function test_one_hundred_simple_get_requests_multiple_methods_route>}
        methods    = [<HookImpl plugin_name='threadexception', plugin=<module '_pytest.threadexception' from 'C:\\hostedtoolcache\\windows\...e=None>>, <HookImpl plugin_name='logging-plugin', plugin=<_pytest.logging.LoggingPlugin object at 0x00000233E0BFAB40>>]
        self       = <_pytest.config.PytestPluginManager object at 0x00000233DBC17320>
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\logging.py#x1B[0m:858: in pytest_runtest_teardown
    #x1B[0m#x1B[94myield#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        item       = <Function test_one_hundred_simple_get_requests_no_session>
        self       = <_pytest.logging.LoggingPlugin object at 0x00000233E0BFAB40>
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\capture.py#x1B[0m:905: in pytest_runtest_teardown
    #x1B[0m#x1B[94mreturn#x1B[39;49;00m (#x1B[94myield#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
            ^^^^^#x1B[90m#x1B[39;49;00m
        item       = <Function test_one_hundred_simple_get_requests_no_session>
        self       = <CaptureManager _method='fd' _global_capturing=<MultiCapture out=<FDCapture 1 oldfd=6 _state='suspended' tmpfile=<_io...._io.TextIOWrapper name='nul' mode='r' encoding='utf-8'>> _state='suspended' _in_suspended=False> _capture_fixture=None>
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\unraisableexception.py#x1B[0m:163: in pytest_runtest_teardown
    #x1B[0mcollect_unraisable(item.config)#x1B[90m#x1B[39;49;00m
        item       = <Function test_one_hundred_simple_get_requests_no_session>
#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\unraisableexception.py#x1B[0m:79: in collect_unraisable
    #x1B[0m#x1B[94mraise#x1B[39;49;00m errors[#x1B[94m0#x1B[39;49;00m]#x1B[90m#x1B[39;49;00m
        config     = <_pytest.config.Config object at 0x00000233DCE1DDF0>
        msg        = 'Exception ignored in: <socket.socket fd=2784, family=2, type=1, proto=0>\n\nTraceback (most recent call last):\n  Fil...ct was allocated.\nSee https://docs.pytest..../stable/how-to/capture-warnings.html#resource-warnings for more info.'
        pop_unraisable = <built-in method pop of collections.deque object at 0x00000233E12EEB60>
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

config = <_pytest.config.Config object at 0x00000233DCE1DDF0>

    #x1B[0m#x1B[94mdef#x1B[39;49;00m#x1B[90m #x1B[39;49;00m#x1B[92mcollect_unraisable#x1B[39;49;00m(config: Config) -> #x1B[94mNone#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
        pop_unraisable = config.stash[unraisable_exceptions].pop#x1B[90m#x1B[39;49;00m
        errors: #x1B[96mlist#x1B[39;49;00m[pytest.PytestUnraisableExceptionWarning | #x1B[96mRuntimeError#x1B[39;49;00m] = []#x1B[90m#x1B[39;49;00m
        meta = #x1B[94mNone#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        hook_error = #x1B[94mNone#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
        #x1B[94mtry#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
            #x1B[94mwhile#x1B[39;49;00m #x1B[94mTrue#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
                #x1B[94mtry#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
                    meta = pop_unraisable()#x1B[90m#x1B[39;49;00m
                #x1B[94mexcept#x1B[39;49;00m #x1B[96mIndexError#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
                    #x1B[94mbreak#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
                #x1B[94mif#x1B[39;49;00m #x1B[96misinstance#x1B[39;49;00m(meta, #x1B[96mBaseException#x1B[39;49;00m):#x1B[90m#x1B[39;49;00m
                    hook_error = #x1B[96mRuntimeError#x1B[39;49;00m(#x1B[33m"#x1B[39;49;00m#x1B[33mFailed to process unraisable exception#x1B[39;49;00m#x1B[33m"#x1B[39;49;00m)#x1B[90m#x1B[39;49;00m
                    hook_error.__cause__ = meta#x1B[90m#x1B[39;49;00m
                    errors.append(hook_error)#x1B[90m#x1B[39;49;00m
                    #x1B[94mcontinue#x1B[39;49;00m#x1B[90m#x1B[39;49;00m
    #x1B[90m#x1B[39;49;00m
                msg = meta.msg#x1B[90m#x1B[39;49;00m
                #x1B[94mtry#x1B[39;49;00m:#x1B[90m#x1B[39;49;00m
>                   warnings.warn(pytest.PytestUnraisableExceptionWarning(msg))#x1B[90m#x1B[39;49;00m
#x1B[1m#x1B[31mE                   pytest.PytestUnraisableExceptionWarning: Exception ignored in: <socket.socket fd=2784, family=2, type=1, proto=0>#x1B[0m
#x1B[1m#x1B[31mE                   Enable tracemalloc to get traceback where the object was allocated.#x1B[0m
#x1B[1m#x1B[31mE                   See https://docs.pytest..../stable/how-to/capture-warnings.html#resource-warnings for more info.#x1B[0m

config     = <_pytest.config.Config object at 0x00000233DCE1DDF0>
msg        = 'Exception ignored in: <socket.socket fd=2784, family=2, type=1, proto=0>\n\nTraceback (most recent call last):\n  Fil...ct was allocated.\nSee https://docs.pytest..../stable/how-to/capture-warnings.html#resource-warnings for more info.'
pop_unraisable = <built-in method pop of collections.deque object at 0x00000233E12EEB60>

#x1B[1m#x1B[31mC:\hostedtoolcache\windows\Python\3.12.10\x64\Lib\site-packages\_pytest\unraisableexception.py#x1B[0m:67: PytestUnraisableExceptionWarning

To view more test analytics, go to the Test Analytics Dashboard
_{📋 Got 3 mins? Take this short survey to help us improve Test Analytics.}

webknjaz · 2025-04-22T11:45:27Z

Missing change log?

for more information, see https://pre-commit.ci

… drop-pytest-plugin

for more information, see https://pre-commit.ci

… drop-pytest-plugin

for more information, see https://pre-commit.ci

… drop-pytest-plugin

for more information, see https://pre-commit.ci

Co-authored-by: Sam Bull <aa6bs0@sambull.org>

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Co-authored-by: Sam Bull <aa6bs0@sambull.org>

Remove pytest_plugin

b2187ea

Dreamsorcerer added the backport:skip Skip backport bot label Apr 20, 2025

Dreamsorcerer requested review from asvetlov and webknjaz as code owners April 20, 2025 22:36

Add to lint requirements too

9618fe0

bdraco and others added 4 commits April 20, 2025 23:04

Merge branch 'master' into drop-pytest-plugin

c73a8bc

recompile

e0e1a5f

Merge branch 'master' into drop-pytest-plugin

3ac806b

Update conftest.py

1c4dbb0

Rename loop to event_loop

b9a3723

Dreamsorcerer marked this pull request as draft April 22, 2025 11:55

pre-commit-ci Bot and others added 17 commits April 22, 2025 11:55

[pre-commit.ci] auto fixes from pre-commit.com hooks

e336f0e

for more information, see https://pre-commit.ci

Rename variables to event_loop

d213299

Merge branch 'drop-pytest-plugin' of github.com:aio-libs/aiohttp into…

c08b15e

… drop-pytest-plugin

[pre-commit.ci] auto fixes from pre-commit.com hooks

3f59011

for more information, see https://pre-commit.ci

Fix

f7d0114

Merge branch 'drop-pytest-plugin' of github.com:aio-libs/aiohttp into…

19520c3

… drop-pytest-plugin

Fix

f27bf61

Fix

bf40464

Fix

13bef44

Fix

b21dead

[pre-commit.ci] auto fixes from pre-commit.com hooks

cf4a292

for more information, see https://pre-commit.ci

Fix

c3649e2

Merge branch 'drop-pytest-plugin' of github.com:aio-libs/aiohttp into…

f789ab0

… drop-pytest-plugin

[pre-commit.ci] auto fixes from pre-commit.com hooks

6cef9ce

for more information, see https://pre-commit.ci

Update conftest.py

c8bb29c

Fix type

6847e95

Update setup.cfg

3c9f8cf

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_run_app.py Outdated

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_run_app.py Outdated

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_run_app.py Outdated

Apply suggestions from code review

d3fd9e6

Co-authored-by: Sam Bull <aa6bs0@sambull.org>

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_proxy_functional.py Outdated

Apply suggestion from @Dreamsorcerer

d064478

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_worker.py Outdated

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_worker.py Outdated

Dreamsorcerer commented May 3, 2026

View reviewed changes

Comment thread tests/test_worker.py Outdated

Apply suggestions from code review

339095e

Co-authored-by: Sam Bull <aa6bs0@sambull.org>