Skip to content

Fix label-remove issue permission#12431

Merged
Dreamsorcerer merged 1 commit intomasterfrom
Dreamsorcerer-patch-5
Apr 27, 2026
Merged

Fix label-remove issue permission#12431
Dreamsorcerer merged 1 commit intomasterfrom
Dreamsorcerer-patch-5

Conversation

@Dreamsorcerer
Copy link
Copy Markdown
Member

Missed the correct permission for issues

@Dreamsorcerer Dreamsorcerer requested a review from webknjaz as a code owner April 27, 2026 21:15
@Dreamsorcerer Dreamsorcerer added the backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot label Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.92%. Comparing base (1842c3e) to head (da523e0).
⚠️ Report is 5 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12431   +/-   ##
=======================================
  Coverage   98.92%   98.92%           
=======================================
  Files         134      134           
  Lines       46751    46751           
  Branches     2430     2430           
=======================================
  Hits        46249    46249           
  Misses        373      373           
  Partials      129      129           
Flag Coverage Δ
CI-GHA 98.98% <ø> (ø)
OS-Linux 98.72% <ø> (ø)
OS-Windows 96.98% <ø> (ø)
OS-macOS 97.89% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.39% <ø> (-0.01%) ⬇️
Py-3.10.20 97.86% <ø> (-0.01%) ⬇️
Py-3.11.15 98.12% <ø> (ø)
Py-3.11.9 97.65% <ø> (ø)
Py-3.12.10 97.74% <ø> (+<0.01%) ⬆️
Py-3.12.13 98.20% <ø> (-0.01%) ⬇️
Py-3.13.13 98.44% <ø> (-0.01%) ⬇️
Py-3.14.4 98.50% <ø> (-0.01%) ⬇️
Py-3.14.4t 97.51% <ø> (-0.01%) ⬇️
Py-pypy3.11.15-7.3.21 97.35% <ø> (-0.01%) ⬇️
VM-macos 97.89% <ø> (+<0.01%) ⬆️
VM-ubuntu 98.72% <ø> (ø)
VM-windows 96.98% <ø> (ø)
cython-coverage 38.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 27, 2026

Merging this PR will not alter performance

✅ 67 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing Dreamsorcerer-patch-5 (da523e0) with master (1842c3e)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on master (25dd890) during the generation of this report, so 1842c3e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Dreamsorcerer Dreamsorcerer added the bot:chronographer:skip This PR does not need to include a change note label Apr 27, 2026
@Dreamsorcerer Dreamsorcerer merged commit 0f0c0e5 into master Apr 27, 2026
48 checks passed
@Dreamsorcerer Dreamsorcerer deleted the Dreamsorcerer-patch-5 branch April 27, 2026 21:50
@patchback
Copy link
Copy Markdown
Contributor

patchback Bot commented Apr 27, 2026

Backport to 3.14: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 0f0c0e5 on top of patchback/backports/3.14/0f0c0e5f963ebd59cc9b604197dea41df7836656/pr-12431

Backporting merged PR #12431 into master

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/aio-libs/aiohttp.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.14/0f0c0e5f963ebd59cc9b604197dea41df7836656/pr-12431 upstream/3.14
  4. Now, cherry-pick PR Fix label-remove issue permission #12431 contents into that branch:
    $ git cherry-pick -x 0f0c0e5f963ebd59cc9b604197dea41df7836656
    If it'll yell at you with something like fatal: Commit 0f0c0e5f963ebd59cc9b604197dea41df7836656 is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 0f0c0e5f963ebd59cc9b604197dea41df7836656
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix label-remove issue permission #12431 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.14/0f0c0e5f963ebd59cc9b604197dea41df7836656/pr-12431
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-3.14 Trigger automatic backporting to the 3.14 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant