ci(depguard): enforce architecture boundaries in lint and CI#130
Open
kangeunchan wants to merge 2 commits intoaltuslabsxyz:mainfrom
Open
ci(depguard): enforce architecture boundaries in lint and CI#130kangeunchan wants to merge 2 commits intoaltuslabsxyz:mainfrom
kangeunchan wants to merge 2 commits intoaltuslabsxyz:mainfrom
Conversation
Signed-off-by: kangeunchan <kangeunchan080310@gmail.com>
Signed-off-by: kangeunchan <kangeunchan080310@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhancement Description
Enforce architecture boundaries in CI with depguard to prevent forbidden dependency directions.
Summary
This PR adds depguard-based architectural checks and documentation so boundary violations are caught automatically during lint/CI.
Previously, boundary enforcement relied heavily on manual review:
Now lint enforces boundary rules and documents the expected dependency direction.
What Changed
1) Enabled depguard architecture rules
Updated:
.golangci.ymlRules enforce boundary constraints for application and ports packages.
2) Added staged allowlist for known legacy violations
3) Added architecture boundary documentation
Added:
docs/architecture-boundaries.mdDocumentation includes:
4) Tests
Validation is lint/CI-focused for this change.
Why This Is Needed
This is an architecture governance improvement.
Automated boundary checks reduce review burden and prevent dependency-direction regressions.
Behavior Notes / Regression Impact
No runtime behavior change.
CI/lint behavior becomes stricter for forbidden imports.
Validation Performed
golangci-lint run --enable-only depguard ./...go test ./...