Align agent guidance with Navigation 3#2105
Open
jelychow wants to merge 2 commits intoandroid:mainfrom
Open
Conversation
The root agent guidance still described Navigation 2 for Compose, but the app now uses the Navigation 3 APIs with NavKey state, NavDisplay, and adaptive scene strategies. Update the architecture note so future agents follow the codebase that is actually present. Constraint: Documentation-only correction for AGENTS.md Rejected: Mention Jetpack Navigation 2 compatibility | the implementation imports androidx.navigation3 and renders with NavDisplay Confidence: high Scope-risk: narrow Tested: git diff --check -- AGENTS.md Tested: rg confirmed androidx.navigation3 imports, NavDisplay usage, and AGENTS.md no longer references Navigation 2 for Compose Not-tested: Full Gradle build not run because this is a documentation-only change
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the AGENTS.md documentation to reflect the transition from Jetpack Navigation 2 to Jetpack Navigation 3, incorporating components like NavKey-based back stacks and NavDisplay. The review feedback suggests refining the description to retain architectural descriptors such as 'state-driven' and 'type-safe' to provide better guidance and improved phrasing.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Notes