runtime: expose Builder::rng_seed without tokio_unstable#8
Open
antsujay wants to merge 1 commit intoanthropics:anthropic-1.49.0from
Open
runtime: expose Builder::rng_seed without tokio_unstable#8antsujay wants to merge 1 commit intoanthropics:anthropic-1.49.0from
antsujay wants to merge 1 commit intoanthropics:anthropic-1.49.0from
Conversation
Moves `Builder::rng_seed`, the `runtime::RngSeed` re-export, and `RngSeed::from_bytes` out of `cfg_unstable!` so callers can seed the scheduler RNG (and thus get deterministic `select!` branch ordering) without `--cfg tokio_unstable`. The underlying `seed_generator` field and all runtime plumbing were already unconditional; only the public setter and type re-export were gated. No behavior change for builds that already set `tokio_unstable`. Upstream tracking issue: tokio-rs#4879 (introduced in tokio-rs#4910).
antsujay
force-pushed
the
rng-seed-stable-v1.49.0
branch
from
947da41 to
64c734e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
Builder::rng_seed, theruntime::RngSeedre-export, andRngSeed::from_bytesout ofcfg_unstable!so callers can seed the scheduler RNG (deterministicselect!branch ordering) without--cfg tokio_unstable.The underlying
seed_generatorfield and all runtime plumbing were already unconditional; only the public setter and type re-export were gated. No behavior change for builds that already settokio_unstable.Tested:
cargo check -p tokio --features full(withouttokio_unstable)cargo check -p tokio --features fullwithRUSTFLAGS="--cfg tokio_unstable"cargo test -p tokio --doc --features full rng_seed(doc example compiles and runs without the cfg)Upstream tracking issue: tokio-rs#4879 (introduced in tokio-rs#4910).
Version bumped to
1.49.0+anthropic.2.